feat(compiler): in package source react skin -> html skin (module)#213
Draft
cjpillsbury wants to merge 3 commits intomainfrom
Draft
feat(compiler): in package source react skin -> html skin (module)#213cjpillsbury wants to merge 3 commits intomainfrom
cjpillsbury wants to merge 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cjpillsbury
force-pushed
the
feat/compiler-v0
branch
from
cf86e26 to
07d5550
Compare
cjpillsbury
commented
Dec 10, 2025
| // https://github.com/antfu/eslint-config/blob/main/src/globs.ts#L56 | ||
| ignores: [ | ||
| '**/CLAUDE.md', | ||
| '**/ARCHITECTURE.md', |
Collaborator
Author
There was a problem hiding this comment.
Low priority thing I'd like to discuss: antfu's linting rules for markdown-owned code blocks is too aggressive for common use cases - it requires syntactically correct code when often what you want is pseudo-code (code with ... and the like), snippets that are technically syntactically invalid (<ReactComponentExample> that isn't e.g. in a return function or assigned to anything), or the like. Whether we convert this to a warning, remove the rule, or try to do something fancier, I think we should fix this so we don't "throw the baby out with the bathwater" on linting markdown.
Member
|
What should be done with this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #244
Overview
This PR is an incomplete implementation of our v0 goals of compiler, which is to:
Take a source file that defines an in-source/package VJS React Skin definition and produce an "appropriately equivalent" version of an in-source/package VJS HTML Skin definition (including styles).
Example:
Given the in-source definition of react
FrostedSkin(and, by association, its tailwind-based styles module), produce an "appropriately equivalent" HTML skin, roughly resembling the current HTML<media-skin-frosted>(and, by association, its "vanilla css"styles).Tasks
High Level notes on complexity