fix(site): suppress noise from llms-markdown integration#705
Closed
fix(site): suppress noise from llms-markdown integration#705
Conversation
Replace `@videojs/react-preview` and `@videojs/html-preview` with the real `@videojs/react` player on the home page. Update HeroVideo to use `createPlayer`, `VideoSkin`/`MinimalVideoSkin`, and `Poster`. Update BaseDemo code snippets to show the real API for both React and HTML (CDN). Remove preview package dependencies from the site. Closes #578 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
# Conflicts: # pnpm-lock.yaml
The PR used `features.video` which doesn't exist in the current API. The correct export is `videoFeatures` from `@videojs/react/video`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Skip standalone error pages (404, 500) that don't have an index.html subdirectory, and strip <style>/<link rel=stylesheet> tags before JSDOM parsing to eliminate 'Could not parse CSS stylesheet' warnings.
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📦 Bundle Size Report
Total: 66.33 kB · 0 B · 0% Entry BreakdownSubpath sizes are the additional bytes on top of the root entry point, measured by bundling root + subpath together and subtracting the root-only size.
|
| Entry | Base | PR | Diff | % | |
|---|---|---|---|---|---|
. |
4.39 kB | 4.39 kB | 0 B | 0% | ✅ |
./dom |
6.03 kB | 6.03 kB | 0 B | 0% | ✅ |
| total | 10.41 kB | 10.41 kB | 0 B | 0% |
@videojs/element
| Entry | Base | PR | Diff | % | |
|---|---|---|---|---|---|
. |
817 B | 817 B | 0 B | 0% | ✅ |
./context |
823 B | 823 B | 0 B | 0% | ✅ |
| total | 1.60 kB | 1.60 kB | 0 B | 0% |
@videojs/html
| Entry | Base | PR | Diff | % | |
|---|---|---|---|---|---|
. |
15.45 kB | 15.45 kB | 0 B | 0% | ✅ |
./video |
9.44 kB | 9.44 kB | 0 B | 0% | ✅ |
./audio |
1.06 kB | 1.06 kB | 0 B | 0% | ✅ |
./background |
1.02 kB | 1.02 kB | 0 B | 0% | ✅ |
| total | 26.98 kB | 26.98 kB | 0 B | 0% |
@videojs/icons
| Entry | Base | PR | Diff | % | |
|---|---|---|---|---|---|
./react |
2.27 kB | 2.27 kB | 0 B | 0% | ✅ |
./html |
1.52 kB | 1.52 kB | 0 B | 0% | ✅ |
./render |
1.59 kB | 1.59 kB | 0 B | 0% | ✅ |
./element |
2.11 kB | 2.11 kB | 0 B | 0% | ✅ |
| total | 7.49 kB | 7.49 kB | 0 B | 0% |
@videojs/store
| Entry | Base | PR | Diff | % | |
|---|---|---|---|---|---|
. |
1.31 kB | 1.31 kB | 0 B | 0% | ✅ |
./html |
472 B | 472 B | 0 B | 0% | ✅ |
./react |
199 B | 199 B | 0 B | 0% | ✅ |
| total | 1.96 kB | 1.96 kB | 0 B | 0% |
@videojs/utils
| Entry | Base | PR | Diff | % | |
|---|---|---|---|---|---|
./array |
104 B | 104 B | 0 B | 0% | ✅ |
./dom |
928 B | 928 B | 0 B | 0% | ✅ |
./events |
227 B | 227 B | 0 B | 0% | ✅ |
./function |
261 B | 261 B | 0 B | 0% | ✅ |
./object |
119 B | 119 B | 0 B | 0% | ✅ |
./predicate |
265 B | 265 B | 0 B | 0% | ✅ |
./string |
148 B | 148 B | 0 B | 0% | ✅ |
./style |
185 B | 185 B | 0 B | 0% | ✅ |
./time |
478 B | 478 B | 0 B | 0% | ✅ |
./number |
158 B | 158 B | 0 B | 0% | ✅ |
| total | 2.81 kB | 2.81 kB | 0 B | 0% |
ℹ️ How to interpret
Sizes are minified + brotli, measured with esbuild.
Package totals are computed as root size + marginal subpath costs.
Subpath marginal cost = (root + subpath bundled together) − root alone.
| Icon | Meaning |
|---|---|
| ✅ | No change |
| 🔺 | Increased ≤ 10% |
| 🔴 | Increased > 10% |
| 🔽 | Decreased |
| 🆕 | New (no baseline) |
Run pnpm size locally to check current sizes.
Collaborator
Author
|
oops messed up my branches easier to just close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The llms-markdown Astro integration was emitting noisy warnings during the build:
404.html), not404/index.html, so the integration would fail trying to read a nonexistent path. Now skipped via aSKIP_PAGESset.Could not parse CSS stylesheetfor every<style>and<link rel="stylesheet">tag. Since the integration only cares about text content, styles are now stripped before parsing.Test plan
pnpm buildinsite/and confirm no JSDOM or file-not-found warnings from the llms-markdown integrationllms.mdandllms-full.mdoutput is unchanged