fix(html): replace display:contents with proper container sizing#812
Open
fix(html): replace display:contents with proper container sizing#812
Conversation
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📦 Bundle Size Report🎨 @videojs/html(no changes) Presets (7)
Media (4)
Players (3)
Skins (15)
UI Components (21)
Sizes are marginal over the root entry point. ⚛️ @videojs/react(no changes) Presets (7)
Media (3)
Skins (14)
UI Components (17)
Sizes are marginal over the root entry point. 🧩 @videojs/core(no changes) Entries (5)
🏷️ @videojs/element(no changes) Entries (2)
📦 @videojs/store(no changes) Entries (3)
🔧 @videojs/utils(no changes) Entries (10)
📦 @videojs/spf(no changes) Entries (3)
ℹ️ How to interpretAll sizes are standalone totals (minified + brotli).
Run |
10b89a0 to
8a4640c
Compare
8a4640c to
b715c66
Compare
Contributor
CI Failure Diagnosis
|
Stop using `display: contents` on `<video-player>` which breaks accessibility tree exposure. Instead, add a `base.css` light-DOM stylesheet that sets `display: block` and proper sizing on the player and media elements, and move the native caption bridge styles there. - Add `@videojs/html/base.css` with player/media layout + caption bridge - Update all sandbox templates and site code examples Closes #808 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
b715c66 to
4c7b103
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
display: contentson<video-player>with a new@videojs/html/base.csslight-DOM stylesheet that sets properdisplay: blocksizing on player and media elements, fixing accessibility tree exposure. Consumers need to include thisbase.cssfile in their own apps.base.css