Skip to content

docs: refactor demo CSS naming and hidden style isolation#826

Draft
mihar-22 wants to merge 2 commits intomainfrom
codex/demo-component-css-isolation
Draft

docs: refactor demo CSS naming and hidden style isolation#826
mihar-22 wants to merge 2 commits intomainfrom
codex/demo-component-css-isolation

Conversation

@mihar-22
Copy link
Member

@mihar-22 mihar-22 commented Mar 10, 2026

Summary

  • replace demo class naming with component-mapped classes (for example .video-player, .media-*) and remove framework/BEM prefixes from API reference demos
  • remove visible scoping markers from demo source (@scope, demo-* scope classes)
  • move demo style isolation into Demo.astro by injecting per-demo scoped CSS at render time
  • stop importing demo CSS directly in demo TSX/ASTRO wrappers; source tabs still show plain CSS
  • update demo authoring docs (site/CLAUDE.md, write-references.mdx) to reflect the new pattern

Validation

  • not run locally in this worktree (dependencies are not installed; astro command missing)

@vercel
Copy link

vercel bot commented Mar 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
v10-sandbox Ready Ready Preview, Comment Mar 10, 2026 10:17am

Request Review

@netlify
Copy link

netlify bot commented Mar 10, 2026

Deploy Preview for vjs10-site ready!

Name Link
🔨 Latest commit 05b3af3
🔍 Latest deploy log https://app.netlify.com/projects/vjs10-site/deploys/69afefca4eaf2000082eb6ec
😎 Deploy Preview https://deploy-preview-826--vjs10-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

📦 Bundle Size Report

🎨 @videojs/html

(no changes)

Presets (7)
Entry Size
/video (default) 22.95 kB
/video (default + hls) 153.33 kB
/video (minimal) 22.81 kB
/video (minimal + hls) 153.26 kB
/audio (default) 21.17 kB
/audio (minimal) 21.15 kB
/background 6.36 kB
Media (4)
Entry Size
/media/background-video 652 B
/media/container 1.86 kB
/media/hls-video 131.32 kB
/media/simple-hls-video 11.38 kB
Players (3)
Entry Size
/video/player 6.22 kB
/audio/player 6.21 kB
/background/player 6.21 kB
Skins (14)
Entry Type Size
/video/minimal-skin.css css 2.74 kB
/video/skin.css css 2.79 kB
/video/minimal-skin js 22.23 kB
/video/minimal-skin.tailwind js 21.48 kB
/video/skin js 22.40 kB
/video/skin.tailwind js 21.52 kB
/audio/minimal-skin.css css 2.17 kB
/audio/skin.css css 2.19 kB
/audio/minimal-skin js 20.58 kB
/audio/minimal-skin.tailwind js 19.71 kB
/audio/skin js 20.62 kB
/audio/skin.tailwind js 19.89 kB
/background/skin.css css 124 B
/background/skin js 1009 B
UI Components (21)
Entry Size
/ui/alert-dialog 2.05 kB
/ui/alert-dialog-close 1.22 kB
/ui/alert-dialog-description 1.16 kB
/ui/alert-dialog-title 1.17 kB
/ui/buffering-indicator 1.71 kB
/ui/captions-button 1.82 kB
/ui/controls 1.79 kB
/ui/fullscreen-button 1.77 kB
/ui/mute-button 1.79 kB
/ui/pip-button 1.77 kB
/ui/play-button 1.77 kB
/ui/playback-rate-button 1.80 kB
/ui/popover 3.06 kB
/ui/poster 1.66 kB
/ui/seek-button 1.81 kB
/ui/slider 2.22 kB
/ui/thumbnail 2.08 kB
/ui/time 1.85 kB
/ui/time-slider 2.92 kB
/ui/tooltip 2.42 kB
/ui/volume-slider 2.19 kB

Sizes are marginal over the root entry point.

⚛️ @videojs/react

(no changes)

Presets (7)
Entry Size
/video (default) 16.67 kB
/video (default + hls) 147.47 kB
/video (minimal) 16.72 kB
/video (minimal + hls) 147.54 kB
/audio (default) 14.39 kB
/audio (minimal) 14.41 kB
/background 3.14 kB
Media (3)
Entry Size
/media/background-video 539 B
/media/hls-video 131.60 kB
/media/simple-hls-video 11.73 kB
Skins (14)
Entry Type Size
/video/minimal-skin.css css 2.74 kB
/video/skin.css css 2.79 kB
/video/minimal-skin js 16.61 kB
/video/minimal-skin.tailwind js 19.17 kB
/video/skin js 16.61 kB
/video/skin.tailwind js 19.23 kB
/audio/minimal-skin.css css 2.17 kB
/audio/skin.css css 2.19 kB
/audio/minimal-skin js 14.34 kB
/audio/minimal-skin.tailwind js 16.13 kB
/audio/skin js 14.27 kB
/audio/skin.tailwind js 16.31 kB
/background/skin.css css 90 B
/background/skin js 272 B
UI Components (17)
Entry Size
/ui/alert-dialog 2.70 kB
/ui/buffering-indicator 2.20 kB
/ui/captions-button 2.26 kB
/ui/controls 2.19 kB
/ui/fullscreen-button 2.28 kB
/ui/mute-button 2.23 kB
/ui/pip-button 2.26 kB
/ui/play-button 2.25 kB
/ui/playback-rate-button 2.24 kB
/ui/popover 3.10 kB
/ui/poster 2.05 kB
/ui/seek-button 2.25 kB
/ui/slider 3.09 kB
/ui/time 2.36 kB
/ui/time-slider 3.24 kB
/ui/tooltip 3.20 kB
/ui/volume-slider 3.08 kB

Sizes are marginal over the root entry point.

🧩 @videojs/core

(no changes)

Entries (5)
Entry Size
. 4.78 kB
/dom 8.02 kB
/dom/media/custom-media-element 1.77 kB
/dom/media/hls 131.18 kB
/dom/media/simple-hls 11.23 kB

🏷️ @videojs/element

(no changes)

Entries (2)
Entry Size
. 999 B
/context 936 B

📦 @videojs/store

(no changes)

Entries (3)
Entry Size
. 1.32 kB
/html 700 B
/react 360 B

🔧 @videojs/utils

(no changes)

Entries (10)
Entry Size
/array 104 B
/dom 1003 B
/events 227 B
/function 261 B
/object 119 B
/predicate 265 B
/string 148 B
/style 190 B
/time 478 B
/number 158 B

📦 @videojs/spf

(no changes)

Entries (3)
Entry Size
. 40 B
/dom 9.48 kB
/playback-engine 9.37 kB

ℹ️ How to interpret

All sizes are standalone totals (minified + brotli).

Icon Meaning
No change
🔺 Increased ≤ 10%
🔴 Increased > 10%
🔽 Decreased
🆕 New (no baseline)

Run pnpm size locally to check current sizes.

@mihar-22 mihar-22 changed the title Refactor docs demo CSS naming and hidden style isolation docs: refactor demo CSS naming and hidden style isolation Mar 10, 2026
@github-actions
Copy link
Contributor

CI Failure Diagnosis

File Type What failed
site/src/components/installation/HTMLUsageCodeBlock.tsx lint Useless switch cases that fall through to default (noUselessSwitchCase).
site/src/components/docs/demos/buffering-indicator/react/css/BasicUsage.tsx lint Formatting mismatch — multiline JSX should be collapsed to single line.
site/src/components/docs/demos/create-player/react/css/BasicUsage.tsx lint Formatting mismatch — multiline button attributes should be collapsed to single line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

1 participant