The measureShortEdge option to use a short edge to display the resolution for vertical video#17
Conversation
|
|
You are definitely right! But in real cases, there is a product owner who needs features like the most popular services do. For example, YouTube, which shows a short edge to display the current quality (in the screenshot). Maybe you can make an option for this feature? |
There was a problem hiding this comment.
Thanks so much for the PR! This makes sense to me.
While Ben's right that p strictly refers to the vertical size of progressive scan video, it's become something of a shorthand for quality/resolution.
However, I think putting it behind an option would be ideal, so that we don't change the behavior out from under users of videojs-contrib-quality-menu.
Perhaps a boolean option called measureShortEdge?
It could be false by default and then in the next major version of the plugin we can flip it to true if there's consensus.
f88aaed to
ec176ee
Compare
measureShortEdge option to use a short edge to display the resolution for horizontal video
measureShortEdge option to use a short edge to display the resolution for horizontal videomeasureShortEdge option to use a short edge to display the resolution for horizontal video
ec176ee to
fef32e9
Compare
measureShortEdge option to use a short edge to display the resolution for horizontal videomeasureShortEdge option to use a short edge to display the resolution for vertical video
…resolution for vertical video
fef32e9 to
2a57041
Compare
mister-ben
left a comment
There was a problem hiding this comment.
Looks good, just a suggestion to add to the option description.
Co-authored-by: mister-ben <1676039+mister-ben@users.noreply.github.com>
|
Hi @misteroneill! I've made the requested changes to the PR as per your feedback. If you have a moment, could you please take another look? Let me know if there’s anything else I can adjust. Thank you! |

Using the minimum side to display the vertical video resolution as popular video players do. In fact, 1280x720 and 720x1280 videos have the same quality, but are now displayed as 720p and 1280p, which is incorrect.