Skip to content

Feat: CSP Issues with setting inline style #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghost wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feat: CSP Issues with setting inline style #621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c371ed
feat: Set inline style via style property to resolve CSP issues
Apr 22, 2024
8913b40
feat: Respect window.VIDEOJS_NO_DYNAMIC_STYLE for setting inline styles
Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions dist/Youtube.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,14 @@ THE SOFTWARE. */
createEl() {
var div = document.createElement('div');
div.setAttribute('id', this.options_.techId);
div.setAttribute('style', 'width:100%;height:100%;top:0;left:0;position:absolute');

if (!window.VIDEOJS_NO_DYNAMIC_STYLE) {
div.style.width = '100%';
div.style.height = '100%';
div.style.top = '0';
div.style.left = '0';
div.style.position = 'absolute';
}
div.setAttribute('class', 'vjs-tech');

var divWrapper = document.createElement('div');
Expand All @@ -103,7 +110,13 @@ THE SOFTWARE. */
if (!_isOnMobile && !this.options_.ytControls) {
var divBlocker = document.createElement('div');
divBlocker.setAttribute('class', 'vjs-iframe-blocker');
divBlocker.setAttribute('style', 'position:absolute;top:0;left:0;width:100%;height:100%');
if (!window.VIDEOJS_NO_DYNAMIC_STYLE) {
divBlocker.style.width = '100%';
divBlocker.style.height = '100%';
divBlocker.style.top = '0';
divBlocker.style.left = '0';
divBlocker.style.position = 'absolute';
}

// In case the blocker is still there and we want to pause
divBlocker.onclick = function() {
Expand Down Expand Up @@ -786,7 +799,9 @@ THE SOFTWARE. */

if (typeof document !== 'undefined'){
loadScript('https://www.youtube.com/iframe_api', apiLoaded);
injectCss();
if (!window.VIDEOJS_NO_DYNAMIC_STYLE) {
injectCss();
}
}

// Older versions of VJS5 doesn't have the registerTech function
Expand Down
Loading