[#15] Mock asset deps: ext-imagick + bundled DejaVu font (U2)#25
Draft
joshuapease wants to merge 1 commit into
Draft
[#15] Mock asset deps: ext-imagick + bundled DejaVu font (U2)#25joshuapease wants to merge 1 commit into
joshuapease wants to merge 1 commit into
Conversation
- Require ext-imagick (already present in CI PHP_EXTENSIONS, no workflow change) - Bundle DejaVuSans.ttf (DejaVu 2.37, Bitstream Vera + Arev license) + its LICENSE - Mark *.ttf binary in .gitattributes so LF normalization can't corrupt it - Font ships in the Composer package (src/ is not export-ignored) - Log font provenance, checksums, and license-compliance analysis in the plan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second PR in the Mock Asset feature series (#15), stacked on #24 (base
branch
jp/15-asset-mock-feature). Review/merge #24 first.U2 adds the feature dependencies the generation work (U7+) needs.
What's here
ext-imagickincomposer.json. No CI change needed —imagickis already in
PHP_EXTENSIONSin bothci.ymlandcodecept.yml.DejaVuSans.ttf(src/resources/fonts/) as the first link in thegenerator's font fallback chain, so text rendering works on slim images that
lack system fonts. Ships in the Composer package (
src/is notexport-ignored).LICENSEalongside the.ttf, as the Bitstream Veralicense requires the notice to accompany redistribution.
*.ttf binaryin.gitattributesso the repo's* text=autorulecan't LF-normalize (corrupt) the binary font.
and a license-compliance analysis.
Font provenance & license
dejavu-fontsGitHub release(
dejavu-fonts-ttf-2.37.tar.bz2), shipped unmodified.7da195a74c55bef988d0d48f9508bd5d849425c1770dba5d7bfc6ce9ed848954Bitstream-Vera). Free to redistribute inside a larger software package,which is our case. Conditions satisfied: notice bundled, never sold
standalone, shipped unmodified (no rename obligation). The font keeps its own
license; it does not become MIT.
Testing
composer validate --no-plugins— manifest valid (the lock-file "out ofdate" note is expected;
composer.lockis git-ignored, CI installs fresh).git check-attrconfirms the font ships (export-ignore: unspecified) and isbinary-safe.