Skip to content

Conversation

@Yami-Yam
Copy link
Contributor

@Yami-Yam Yami-Yam commented Dec 3, 2024

We've added additional page for a survey form and a download button as per Sir Poul requested to be added. For the survey we've just used firebase for its database and as for the download button it just links to 404 at the moment.

@codesandbox
Copy link

codesandbox bot commented Dec 3, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@vercel
Copy link

vercel bot commented Dec 3, 2024

@Yami-Yam is attempting to deploy a commit to the Vignette Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@sr229 sr229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a glaring security issue here.

import { initializeApp, getApps, getApp } from "firebase/app";
import { getFirestore } from "firebase/firestore";

const firebaseConfig = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

send this config to me privately and re-generate it. You're not supposed to place secrets inside the repository.

@Yami-Yam Yami-Yam closed this Dec 5, 2024
@Yami-Yam Yami-Yam deleted the master branch December 5, 2024 16:24
@Yami-Yam Yami-Yam restored the master branch December 5, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants