add module for spin filter#243
Conversation
md-arif-shaikh
force-pushed
the
filter_spin
branch
from
842da37 to
a1d361c
Compare
|
Implements filtering of spin-induced sub-orbitalscale oscillations in amplitude/frequency. Follows the procedure described in Sec. 2.7 of https://arxiv.org/pdf/2507.08345 |
|
Hi @vijayvarma392, at this point I would like to have comments on this PR. I have prepared a diagnostic pdf for precessing NR cases for the LVK review. Here is a version with about 20 cases. |
|
Comparing eSpEC vs egw at initial times |
|
@vijayvarma392 just a reminded that we need to merge this as soon as possible for the LVK review. |
vijayvarma392
left a comment
vijayvarma392
left a comment
There was a problem hiding this comment.
Only minor comments, looks good otherwise.
|
|
||
|
|
||
| def _pn_model(t, t_merger, A, power): | ||
| """Post-Newtonian model for secular trend. |
There was a problem hiding this comment.
Add a reference for this formula if you have one
| f"Unknown fit data type: {data_type}. " | ||
| f"Allowed data types are: {allowed_data_types}") | ||
|
|
||
| power = -3.0/8.0 if data_type == "omega" else -1.0/4.0 |
|
|
||
| We set the requirement for filtering to True when the mode asymmetry | ||
| becomes greater than a threshold fraction of (2, 2) mode in the | ||
| coprecessing frame. |
There was a problem hiding this comment.
Refer to the section of the paper where this is discussed. Do similar references throughout this code, as necessary.
| def _get_fcut_fecc_fspin(t, data, f_spin_guess, | ||
| fspin_lo_frac, fspin_hi_frac, | ||
| fecc_lo_frac, fecc_hi_frac, verbose): | ||
| """Get f_cutoff, f_ecc, and f_spin from the amplitude spectrum. |
There was a problem hiding this comment.
Refer to the section in the paper
|
@vijayvarma392 can you have another look? |
|
@vijayvarma392 gentle reminder. |
2 participants
No description provided.