add submodule for postprocessing#246
Conversation
There was a problem hiding this comment.
Should the examples live with the other examples here? Otherwise, anyone that installs gwecc will get these examples in their python dirs. I'm thinking a postprocessing directory in examples, along with a mention of this and what it does in the main Readme.
There was a problem hiding this comment.
In the example notebooks, it looks like there are huge outputs of warnings. We need to say something in the notebooks about this: what should people make of them, should they ignore them, etc.
There was a problem hiding this comment.
Yes, agree. Moved the examples to top level examples/postprocessing. Added a subsection in the Usage section in the main Readme.
Yes, I have cleaned up the notebook. Have another look, it looks much better. Earlier there were two sources for long outputs -- one was because I was using posterior for lower eccentricity and some of the samples were failing (because I was using Amplitude). Others were coming from rational_fit. Changed both and the notebook looks much more cleaner now.
| @@ -0,0 +1,109 @@ | |||
| import numpy as np | |||
There was a problem hiding this comment.
Explain why this file exists at the top?
There was a problem hiding this comment.
Done. Also renamed the file.
|
|
||
| A wrapper around ``gw_eccentricity.measure_eccentricity`` to measure | ||
| eccentricity from the waveform modes for a sample with given ``params``. | ||
|
|
There was a problem hiding this comment.
Is this the main function the user sees?
Whichever function that is, could you describe the entire procedure in the docs? Like how the frequency ranges are chosen, etc.
There was a problem hiding this comment.
Okay. Shall I expand the docs for the params? or are you suggesting for a detailed description at the top of the function docstring?
There was a problem hiding this comment.
Added some details on the range of allowed tref/fref at the top.
|
@vijayvarma392 could you have another look? |
2 participants
Mains files to review:
Example dir contains notebooks and scripts to showcase postprocessing Bilby posterior.