Add Microsoft.Polarbear resource provider spec#15
Open
vikeshi26 wants to merge 210 commits into
Open
Conversation
…s for the new RP's
…nu/azure-rest-api-specs into tejaswis/detectNewRPs
…nu/azure-rest-api-specs into tejaswis/detectNewRPs
… commit is generated The checkLease function was reading the lease file from HEAD^ (the base branch parent of the merge commit). This failed when: 1. A spec PR is pushed (generating a merge commit based on main at that point) 2. The lease PR is merged to main AFTER the merge commit was generated 3. The CI runs - HEAD^ still points to the old main WITHOUT the lease file Fix: Add fallback to origin/<GITHUB_BASE_REF> in checkLease, which reflects the current state of the base branch. The workflow also now fetches the base branch to ensure origin/<base_ref> is available for this fallback check. Co-authored-by: tejaswiMinnu <14865963+tejaswiMinnu@users.noreply.github.com> Agent-Logs-Url: https://github.com/tejaswiMinnu/azure-rest-api-specs/sessions/ed82f09d-11d5-46f9-a81b-674badd9b966
…describe+beforeEach Replace nested describe blocks with beforeEach/afterEach for GITHUB_BASE_REF management with the canonical vi.stubEnv() pattern (consistent with avocado-code.test.js). Also clean up detect-arm-leases.js: use const for content variables in each try block, remove redundant comment, and clarify the empty catch block comment. Co-authored-by: tejaswiMinnu <14865963+tejaswiMinnu@users.noreply.github.com> Agent-Logs-Url: https://github.com/tejaswiMinnu/azure-rest-api-specs/sessions/c1e968c0-88b7-483c-85d6-8d997973e8e7
…modeling-review-failure Fix ARM Modeling Review false failure when lease merges after PR's merge commit is generated
Co-authored-by: tejaswiMinnu <14865963+tejaswiMinnu@users.noreply.github.com> Agent-Logs-Url: https://github.com/tejaswiMinnu/azure-rest-api-specs/sessions/2fb5d474-67e2-4675-93e8-9e56d8e46779
…e-for-service-group Add ARM lease for Microsoft.XYZ/XYZMonitor service group
…thub/arm-leases/testrop/Microsoft.TestROP/arm-leases/testrop/Microsoft.TestROP/TestROP/lease.yaml
…p/Microsoft.TestROP/TestROP/lease.yaml to .github/arm-leases/testrop/Microsoft.TestROP/TestROP/lease.yaml
Next Steps to MergeNext steps that must be taken to merge this PR:
Important checks have failed. As of today they are not blocking this PR, but in near future they may. Addressing the following failures is highly recommended:
Comment generated by summarize-checks workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
Click here to open a PR for only SDK configuration.