Skip to content

Fix for errors when trying to add a new machine definition#279

Open
jdow749 wants to merge 1 commit intovilemduha:masterfrom
jdow749:master
Open

Fix for errors when trying to add a new machine definition#279
jdow749 wants to merge 1 commit intovilemduha:masterfrom
jdow749:master

Conversation

@jdow749
Copy link
Copy Markdown

@jdow749 jdow749 commented Jan 6, 2025

Cool project! Tried to follow the intro video using Blender 4.21 and got the following error when I tried to add a new machine definition for my Shapeoko 4 XXL.

image

Looks like a commit last month changed these (and some other) variable names and broke this. I updated to the new names where needed. Hope this helps!

@SpectralVectors
Copy link
Copy Markdown
Contributor

Hi @jdow749 , thanks for contributing the code - development primarily happens on @pppalain or @SpectralVectors branches, with changes pushed here once they stabilize. Apologies, we should do a better job of letting people know where to submit Pulls.
It looks like the Preset Operator has already been patched, but when I checked the Preset files themselves there were a number that required both fixes you posted here, so they have now been updated and will soon be pushed to this branch.
If you're interested in contributing you can join the Matrix chat, or submit Pulls to @pppalain or @SpectralVectors where they can get worked into the experimental branch before moving on to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants