Skip to content

make_qualified_base_name: qbn string view #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
villagestevers merged 2 commits into from
May 5, 2026
Merged

make_qualified_base_name: qbn string view #419

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a831bf8
make_qualified_base_name: use std::string_view
pyshx May 1, 2026
57bdbaf
make_qualified_base_name: reserve+append, no temporaries
pyshx May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions villagesql/schema/systable/helpers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,14 @@ std::string normalize_extension_name(const std::string &name);
std::string normalize_type_name(const std::string &name);

// Build a qualified base name string "extension_name.type_name".
inline std::string make_qualified_base_name(const std::string &extension_name,
const std::string &type_name) {
return extension_name + "." + type_name;
inline std::string make_qualified_base_name(std::string_view extension_name,
Comment thread
villagestevers marked this conversation as resolved.
std::string_view type_name) {
std::string result;
result.reserve(extension_name.size() + 1 + type_name.size());
result.append(extension_name);
result.push_back('.');
result.append(type_name);
return result;
}

// Returns true if name is a qualified custom type name (contains a dot),
Expand Down
Loading