Add ABI interface for custom index#436
Open
villagedeb wants to merge 1 commit intomainfrom
Open
Conversation
malone-at-work
approved these changes
May 7, 2026
| #define VEF_INDEX_CAP_REVERSE_SCAN ((vef_index_cap_t)1u << 2) | ||
| // Index scan returns results in key order, allowing the optimizer to satisfy | ||
| // ORDER BY on the index columns without a separate sort step. | ||
| #define VEF_INDEX_CAP_ORDER_BY ((vef_index_cap_t)1u << 3) |
Member
There was a problem hiding this comment.
Is this implied by RANGE_SCAN? I am trying to figure out if these are all completely independent capabilities.
| // Opaque index descriptor reference from MySQL/InnoDB | ||
| typedef void *vef_index_ref_t; | ||
|
|
||
| // Naming convention for function pointer typedefs in this header: |
Member
There was a problem hiding this comment.
Is this only in this header? We should have standardized conventions across headers.
| // error_msg - Output: error description on failure | ||
| // error_msg_len - length of error message buffer | ||
| // Returns false on success, true on error (writes to error_msg). | ||
| typedef bool (*vef_type_index_insert_func_t)( |
Member
There was a problem hiding this comment.
why vef_type_index as opposed to vef_index_. When to use 'type'?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.