ALTER TABLE custom column to string#45
Merged
Merged
Conversation
tomas-villagesql
changed the title
tomas-villagesql
force-pushed
the
tomas/alter-table-custom-to-string
branch
from
84ed443 to
5c87e68
Compare
tomas-villagesql
changed the title
tomas-villagesql
force-pushed
the
tomas/alter-table-custom-to-string
branch
4 times, most recently
from
99880d8 to
8fac3e5
Compare
tomas-villagesql
force-pushed
the
tomas/alter-table-custom-to-string
branch
from
8fac3e5 to
4188726
Compare
| assert(from->has_type_context()); | ||
| assert(to->result_type() == STRING_RESULT); | ||
| // Custom → non-custom string: decode to string representation. | ||
| char buff[MAX_FIELD_WIDTH]; |
Member
There was a problem hiding this comment.
This seems to be 255*3+1, but what about long vectors? Should we be using MAX_FIELD_WIDTH or something that is from the type context?
Member
Author
There was a problem hiding this comment.
this is a longer investigation
Member
There was a problem hiding this comment.
You can put a todo here if you want to check this change in as is.
Member
Author
There was a problem hiding this comment.
now uses dynamic string like do_field_string in mysql does
villagestevers
approved these changes
Feb 24, 2026
| assert(from->has_type_context()); | ||
| assert(to->result_type() == STRING_RESULT); | ||
| // Custom → non-custom string: decode to string representation. | ||
| char buff[MAX_FIELD_WIDTH]; |
Member
There was a problem hiding this comment.
You can put a todo here if you want to check this change in as is.
|
|
||
| UPDATE t1 SET complex_val='(2.0,-3.0)' WHERE id=3; | ||
|
|
||
| ALTER TABLE t1 CHANGE complex_val string_val VARCHAR(99) NOT NULL; |
Member
There was a problem hiding this comment.
Curious why 99 now :-) No need to change.
Member
Author
There was a problem hiding this comment.
99, because other is 100, to see which alter ends up in the binlog
villagestevers
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.