storage: Use MtxCtx#481
Open
malone-at-work wants to merge 1 commit into
Open
Conversation
malone-at-work
force-pushed
the
maloney/storage-preview/2
branch
2 times, most recently
from
2bbcb97 to
93e0be9
Compare
malone-at-work
force-pushed
the
maloney/storage-preview/3
branch
from
3f67159 to
f572d06
Compare
malone-at-work
requested review from
villagedeb
and removed request for
dbentley-vsql
villagedeb
approved these changes
May 14, 2026
|
|
||
| alignas(std::max_align_t) unsigned char m_buf[MAX_STACK_SIZE]; | ||
| unsigned char *m_heap_buf = nullptr; | ||
| size_t m_heap_size = 0; |
Member
There was a problem hiding this comment.
Just a note: for a borrowed MTR context, the 1.5 KB stack allocation would effectively go unused, though I don't see any major concern with it.
Member
Author
There was a problem hiding this comment.
Oh right - I meant to make that optional, but I did not. I will clean this up after 0.0.4.
malone-at-work
added
the
Waiting next release
villagestevers
removed
the
Waiting next release
It is strongly typed and is passed as const in hooks that don't start or commit Mtx.
malone-at-work
force-pushed
the
maloney/storage-preview/3
branch
from
f572d06 to
7821f9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is strongly typed and is passed as const in hooks that don't start or commit the MtrCtx.