Skip to content

TypeParameters to use string_view#514

Merged
villagestevers merged 3 commits into
villagesql:mainfrom
anand-trehan:anand/use_string_view
May 15, 2026
Merged

TypeParameters to use string_view#514
villagestevers merged 3 commits into
villagesql:mainfrom
anand-trehan:anand/use_string_view

Conversation

@anand-trehan
Copy link
Copy Markdown
Contributor

@anand-trehan anand-trehan commented May 14, 2026

Description

Refactored TypeParameters to use string_view while parsing the raw string.

The function changed is TypeParameters::from_raw in 'type_context.cc'.

Related Issue

#363

How was this tested?

  • Debug Build cmake ~/villagesql-server -DWITH_DEBUG=1 -DWITH_SSL=system followed by make -j $(($(getconf _NPROCESSORS_ONLN) - 2))
  • Run village-sql unit tests ctest -L villagesql
  • Run village test suite 'mysql-test/mysql-test-run.pl --do-suite=village --nounit-tests --parallel=auto'

Checklist

  • I have signed the CLA
  • I have read CONTRIBUTING.md
  • I have added or updated tests as appropriate
  • My changes maintain compatibility with upstream MySQL 8.4

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@anand-trehan
Copy link
Copy Markdown
Contributor Author

anand-trehan commented May 14, 2026

I have read the CLA Document and I hereby sign the CLA

@anand-trehan
Copy link
Copy Markdown
Contributor Author

Recheck

@anand-trehan anand-trehan marked this pull request as ready for review May 15, 2026 04:15
@villagestevers
Copy link
Copy Markdown
Member

Closes #363

I opened 518 as a follow on.

@villagestevers villagestevers changed the title Refactor TypeParameters : Use string_view Refactor TypeParameters to use string_view May 15, 2026
@villagestevers villagestevers changed the title Refactor TypeParameters to use string_view Refactor TypeParameters to use string_view May 15, 2026
@villagestevers villagestevers changed the title Refactor TypeParameters to use string_view TypeParameters to use string_view May 15, 2026
Copy link
Copy Markdown
Member

@villagestevers villagestevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run scripts/villint (PR validation is failing)

I changed the title to be shorter thinking that was the only problem, but linting is the issue.

Also, please don't use merge commits in the future. The villint change should be layered on as a separate commit. We squash and merge at the end, so we only rebase after approval.

Thanks!

@anand-trehan
Copy link
Copy Markdown
Contributor Author

Okay I ran the linting script and created a new commit. Thanks for the feedback will keep in mind not to use merge commits from here on. Let me know if this looks good now.

Thanks!

@villagestevers
Copy link
Copy Markdown
Member

Thanks @anand-trehan - I will squash and merge your change in once the CI finishes. Please join our discord if you have not already! (makes coordinating easier)

@villagestevers villagestevers merged commit 091c1e1 into villagesql:main May 15, 2026
3 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants