TypeParameters to use string_view#514
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Recheck |
|
Closes #363 I opened 518 as a follow on. |
villagestevers
left a comment
There was a problem hiding this comment.
You need to run scripts/villint (PR validation is failing)
I changed the title to be shorter thinking that was the only problem, but linting is the issue.
Also, please don't use merge commits in the future. The villint change should be layered on as a separate commit. We squash and merge at the end, so we only rebase after approval.
Thanks!
|
Okay I ran the linting script and created a new commit. Thanks for the feedback will keep in mind not to use merge commits from here on. Let me know if this looks good now. Thanks! |
|
Thanks @anand-trehan - I will squash and merge your change in once the CI finishes. Please join our discord if you have not already! (makes coordinating easier) |
Description
Refactored TypeParameters to use string_view while parsing the raw string.
The function changed is
TypeParameters::from_rawin 'type_context.cc'.Related Issue
#363
How was this tested?
cmake ~/villagesql-server -DWITH_DEBUG=1 -DWITH_SSL=systemfollowed bymake -j $(($(getconf _NPROCESSORS_ONLN) - 2))ctest -L villagesqlChecklist