incompatible custom types block#60
Merged
tomas-villagesql merged 4 commits intomainfrom Feb 26, 2026
Merged
Conversation
tomas-villagesql
force-pushed
the
tomas/incompatible-custom-type-cast
branch
from
ba9d5e4 to
6fc16cd
Compare
| CREATE TABLE t_mixed (id INT, complex_val COMPLEX, complex2_val COMPLEX2, int_val INT); | ||
| INSERT INTO t_mixed VALUES (1, '(1.0,1.0)', '(2.0,2.0)', 100); | ||
| UPDATE t_mixed SET complex2_val = complex_val WHERE id = 1; | ||
| ERROR HY000: Cannot implicitly cast from vsql_complex.COMPLEX to vsql_complex.COMPLEX2 for column 'complex2_val' at row 1 |
Member
There was a problem hiding this comment.
This test should probably be for tvector, since this should be failing even before this change
Member
Author
There was a problem hiding this comment.
added vector test
villagestevers
approved these changes
Feb 26, 2026
| void TypeContext::resolve_cached_values() { | ||
| // Build qualified_name_ once: "ext.type" or "ext.type(v1,v2,...)" | ||
| qualified_name_ = descriptor_->qualified_base_name(); | ||
| if (!key_.parameters().empty()) { |
Member
There was a problem hiding this comment.
This won't match what we need for SHOW CREATE TABLE (which is sitting in a branch of mine waiting to rebase on Mike's changes). In particular, we support TYPE(N) and TYPE('k1=v1,k2=v2,...').
I am fine if you want this as a placeholder for now, but I ask you put a TODO here so that I remember to update it when I make my next changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.