Repository navigation
Require the Doctrine plugin, and enable it when composer.json requires Doctrine - #14165
Merged
Merged
Conversation
…s Doctrine weirdan/doctrine-psalm-plugin is enabled like the psalm/* plugins when composer.json requires doctrine/orm, doctrine/dbal, doctrine/collections or doctrine/persistence.
Contributor
✅ Performance: unchanged · Issues: unchanged
How to read this table
composer.json changed in this PR, so head dependencies were re-resolved; memory and time deltas are informational. head 99683f7 · base 9564722 (merge-base) · workflow run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Psalm doesn't enable the Doctrine plugin by itself, as it does the PHPUnit, Mockery, Symfony and Laravel ones, so a Doctrine project gets neither its types nor its taint sinks and sources unless it installs and enables it.
Before
{"require": {"doctrine/orm": "^3"}}no plugin enabled
After
Weirdan\DoctrinePsalmPlugin\Pluginenabled, also whencomposer.jsonrequiresdoctrine/dbal,doctrine/collectionsordoctrine/persistence.