Skip to content

Require the Doctrine plugin, and enable it when composer.json requires Doctrine - #14165

Merged
danog merged 2 commits into
vimeo:masterfrom
danog:bundle-doctrine-plugin
Nov 18, 2026
Merged

danog merged 2 commits into
vimeo:masterfrom
danog:bundle-doctrine-plugin

Conversation

@danog

@danog danog commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Psalm doesn't enable the Doctrine plugin by itself, as it does the PHPUnit, Mockery, Symfony and Laravel ones, so a Doctrine project gets neither its types nor its taint sinks and sources unless it installs and enables it.

Before

{"require": {"doctrine/orm": "^3"}}

no plugin enabled

After

Weirdan\DoctrinePsalmPlugin\Plugin enabled, also when composer.json requires doctrine/dbal, doctrine/collections or doctrine/persistence.

…s Doctrine

weirdan/doctrine-psalm-plugin is enabled like the psalm/* plugins when
composer.json requires doctrine/orm, doctrine/dbal, doctrine/collections or
doctrine/persistence.
@danog danog added the release:feature The PR will be included in 'Features' section of the release notes label Nov 18, 2026
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

✅ Performance: unchanged · Issues: unchanged

Project Memory (MB) Wall (s) Issues Weighted
✅ laravel 1 712 87.9 $\color{gray}{\textsf{-1.3\%}}$ 26 029 50 892
✅ symfony 3 622 223.1 $\color{gray}{\textsf{+1.3\%}}$ 50 788 99 170
✅ doctrine-orm 393 20.7 $\color{gray}{\textsf{-1.1\%}}$ 3 527 5 603
✅ psl 632 25.6 $\color{gray}{\textsf{-1.0\%}}$ 1 312 5 104
✅ phpunit 471 20.2 $\color{gray}{\textsf{-0.5\%}}$ 1 604 1 207
✅ php-parser 237 13.8 $\color{gray}{\textsf{-0.4\%}}$ 17 133 20 547
✅ tempest 893 35.9 $\color{gray}{\textsf{+0.1\%}}$ 4 942 9 279
✅ amphp-amp 61 1.4 $\color{gray}{\textsf{-2.0\%}}$ 29 49
✅ webmozarts-assert 285 3.3 $\color{gray}{\textsf{+0.9\%}}$ 577 2 720
✅ guzzle-promises 55 1.4 $\color{gray}{\textsf{-9.4\%}}$ 161 406
✅ monolog 153 4.2 $\color{gray}{\textsf{+6.0\%}}$ 907 2 191
✅ drupal 4 782 239.2 $\color{gray}{\textsf{-2.2\%}}$ 98 209 160 246
Total 13 295 676.6 $\color{gray}{\textsf{-0.6\%}}$ 205 218 357 414
How to read this table
  • Memory: Psalm's own peak figure, threads=1. More than +5 % fails, unless the PR changes composer.json.
  • Wall: base and head run on the same runner; ±10 % is noise. Above +20 % warns, never fails. re-run: a reversed second run was taken and the faster kept.
  • Issues: head count, then $\color{red}{\textsf{+added}}$ $\color{green}{\textsf{-removed}}$ against base.
  • Weighted: issues weighted by error level (levels 1–8 as is, always-errors 10, feature-specific and purity suggestions 0). The projects' own code is pinned and their dependencies resolve identically for base and head, so a change means Psalm reports more, fewer or differently serious issues. A rise is not necessarily a regression.
  • Total: sum over the projects compared on both sides. Thresholds apply per project, not to the total.
  • Colors: $\color{red}{\textsf{red}}$ past a fail or warn threshold (or more issues), $\color{green}{\textsf{green}}$ an improvement past noise (or fewer issues), $\color{gray}{\textsf{gray}}$ noise.
  • Performance: regressed if a head run crashed or timed out or a memory or wall delta is red, else improved if one is green, else unchanged. Its icon is the check result: ❌ fail · ⚠️ warn · ✅ pass; the icon next to each project is that project's result, 💥 = not comparable: base crashed or timed out (counts as ⚠️).
  • Issues (heading): the total weighted change, increased · decreased · unchanged, followed by the issues added and removed across the projects, e.g. increased (+175 −128). If the weighted total is zero but issues were added or removed (those weighted 0 changed, or changes offset), it reads changed (+175 −128, weighted unchanged). Informational, never fails the check.

composer.json changed in this PR, so head dependencies were re-resolved; memory and time deltas are informational.

head 99683f7 · base 9564722 (merge-base) · workflow run

@danog
danog merged commit 90d3267 into vimeo:master Nov 18, 2026
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:feature The PR will be included in 'Features' section of the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant