Skip to content

Conversation

@vinaygaba
Copy link
Owner

Upgrade the repository to the latest Jetpack Compose, Gradle, and Android tooling standards to ensure it remains a canonical and accurate resource.


Open in Cursor Open in Web

@cursor
Copy link

cursor bot commented Sep 1, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@vinaygaba
Copy link
Owner Author

@cursoragent the build is failing. Can you check what the issues are

@cursor
Copy link

cursor bot commented Sep 2, 2025

I updated the GitHub Actions workflow for Android builds, migrating to newer action versions, JDK 17, and explicitly setting up the Android SDK. I also refactored the Jetpack Compose Scaffold and BottomAppBar usage to align with the latest API for integrating a floating action button.

  • I upgraded the GitHub Actions workflow in .github/workflows/android.yml:
    • Updated actions/checkout from v2 to v4 and actions/setup-java from v1 to v4.
    • Migrated the JDK version from 11 to 17, specifying distribution: 'temurin'.
    • Added a step to set up the Android SDK using android-actions/setup-android@v3 and installed necessary SDK components (platform-tools, platforms;android-35, build-tools;35.0.0) after accepting licenses.
    • Changed the ui-testing job's runner from macos-10.15 to macos-latest.
  • In app/src/main/java/com/example/jetpackcompose/material/FixedActionButtonActivity.kt, I refactored the Scaffold and BottomAppBar implementation:
    • Removed the deprecated cutoutShape parameter from BottomAppBar.
    • Moved the FloatingActionButton directly into the BottomAppBar's floatingActionButton slot.
    • Removed isFloatingActionButtonDocked and floatingActionButtonPosition from the Scaffold as these are now implicitly handled by the BottomAppBar's internal layout when the FAB is placed within its dedicated slot.

Open in Cursor Open in Web

Learn more about Cursor Agents

@vinaygaba vinaygaba closed this Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants