Reorder overlay: stop placeholder animating up from zero on insert#122
Merged
Conversation
The dashed .reorder-placeholder carried `transition: height .2s ease`, so every time a drag started the placeholder (created detached with its target height set inline, then inserted into the list) animated up from ~0 to its full height over 200 ms. The floating pill, which doesn't transition, appeared at full height immediately — making the placeholder visibly shorter than the pill during the drag. The transition was dead code: the placeholder's height is set once at creation (admin.js:5065) and never written again. Dropping the transition makes the placeholder render at full height instantly, matching the pill. https://claude.ai/code/session_01TZA17yUsrhNLFMW39M87gF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dashed .reorder-placeholder carried
transition: height .2s ease,so every time a drag started the placeholder (created detached with its
target height set inline, then inserted into the list) animated up from
~0 to its full height over 200 ms. The floating pill, which doesn't
transition, appeared at full height immediately — making the placeholder
visibly shorter than the pill during the drag.
The transition was dead code: the placeholder's height is set once at
creation (admin.js:5065) and never written again. Dropping the transition
makes the placeholder render at full height instantly, matching the pill.
https://claude.ai/code/session_01TZA17yUsrhNLFMW39M87gF