Fix timeline section hiding in print output on mobile#126
Merged
Conversation
Hiding the timeline section via the section-visibility toggle (.is-hidden)
was supposed to omit it from print, but it rendered as a dimmed, dashed
box. The mobile-print re-enable rule used
#section-timeline:not(.hidden-print) — higher specificity than the
generic .is-hidden { display: none !important } rule — so it won in print
and the .is-hidden opacity styling from admin.css leaked through.
Extend the :not() guard to also exclude .is-hidden so genuinely hidden
timelines are absent from print on every viewport width.
https://claude.ai/code/session_01NjtKez7wnZgJrBfDnioPrw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a CSS specificity bug where hiding the timeline section via the section-visibility toggle (
.is-hiddenclass) was not being respected in print output on mobile viewports. The timeline would still appear as a faded, dashed-border block instead of being completely omitted.The root cause was that the mobile print override rule
#section-timeline:not(.hidden-print)had higher specificity than the generic.is-hidden { display: none !important; }rule, causing the override to win and re-enable the timeline even when the user had hidden it.The fix adds
:not(.is-hidden)to both mobile print override selectors, ensuring that genuinely hidden timelines are absent from print output on all viewport widths. Hiding non-timeline sections was already working correctly; this bug was specific to the timeline because it's the only section with a mobile-print re-enable rule.Type of Change
Checklist
Required for all code changes
npm testpasses)package.json,package-lock.json,version.json)CHANGELOG.mdhas been updated with a new entry under the correct versionIf adding or changing user-visible strings
If documentation-only change
https://claude.ai/code/session_01NjtKez7wnZgJrBfDnioPrw