Skip to content

issue-87 Supports the LIMIT 10,5 syntax. #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
china-zhz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

issue-87 Supports the LIMIT 10,5 syntax. #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...m/github/vincentrussell/query/mongodb/sql/converter/holder/from/SQLCommandInfoHolder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ public Builder setPlainSelect(final PlainSelect plainSelect)
from = generateFromHolder(new FromHolder(this.defaultFieldType,
this.fieldNameToFieldTypeMapping), plainSelect.getFromItem(), plainSelect.getJoins());
limit = SqlUtils.getLimitAsLong(plainSelect.getLimit());
offset = SqlUtils.getOffsetAsLong(plainSelect.getOffset());
offset = SqlUtils.getOffsetAsLong(plainSelect.getLimit(), plainSelect.getOffset());
orderByElements = plainSelect.getOrderByElements();
selectItems = plainSelect.getSelectItems();
joins = plainSelect.getJoins();
Expand Down
7 changes: 6 additions & 1 deletion src/main/java/com/github/vincentrussell/query/mongodb/sql/converter/util/SqlUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,12 +241,17 @@ public static long getLimitAsLong(final Limit limit) throws ParseException {

/**
* get offset as long.
* @param limit the limit
* @param offset the offset
* @return the offset
*/
public static long getOffsetAsLong(final Offset offset) {
public static long getOffsetAsLong(final Limit limit, final Offset offset) throws ParseException {
if (offset != null && LongValue.class.isInstance(offset.getOffset())) {
return ((LongValue) offset.getOffset()).getValue();
} else {
if (limit != null) {
return getLongFromStringIfInteger(SqlUtils.getStringValue(limit.getOffset()));
}
}
return -1;
}
Expand Down