RPM Build script && Use host glibmm by dhilst · Pull Request #96 · viniciusferrao/cloysterhpc

dhilst · 2025-02-25T17:53:43Z

Add a small script and a .spec file to generate the RPM

-- Edit --

glibmm was linking dynamically from connan
The problem is that the generated rpm cannot depend on connan shared objects because they will not exist in the host (if the tool wasn't built there)
To solve this, we have to link against host's glibmm
To do that, I load pkg-config module into cmake before conan
And use it to find glibmm-2.4
I decided to test with RHEL10, and the build fails because glibmm is at 2.68 version (we're using 2.66), and pkg-config can't find glibmm-2.4 package. 2.4 was the ABI, which was supposed to be stable, but here we are. All the code depending on glibmm was moved to files.cpp to mitigate the problem and should be kept there
I added the buildrpm.sh script to generate an RPM in the host, so this is expected to run in the build machine with the proper OS, etc, the rpm is generated at ~/rpmbuild/RPMS/ folder, as usual. The .spec file is not being generated by CPack

sonarqubecloud · 2025-03-07T18:36:38Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

dhilst · 2025-03-17T17:11:48Z

I'm merging this into repo-class to narrow the number of PR stacked

viniciusferrao · 2025-03-13T02:09:04Z


+
+std::string checksum(const std::string& data);
+std::string checksum(const std::filesystem::path& path, const std::size_t chunkSize = 16384);


The magic number should be a constexpr std::uint_fast16_t elsewhere.

viniciusferrao · 2025-03-21T18:41:16Z

+License: Apache 2.0
+URL: https://versatushpc.com.br/opencattus/
+Source0: opencattus-%{VERSION}.tar.gz
+BuildRequires: make,cmake,cppcheck,ninja-build,newt-devel,gcc-toolset-14,gcc-toolset-14-libubsan-devel,gcc-toolset-14-libasan-devel


It's a good idea to target what will be shipped in RHEL 10. I don't remember the version they are targetting.

viniciusferrao · 2025-03-21T18:41:37Z

+/usr/bin/cloysterhpc
+
+%changelog
+* Tue Feb 25 2025 Daniel Hilst <danielhilst@versatushpc.com> - 1.0-1


Your own email address is wrong.

viniciusferrao · 2025-03-21T18:43:02Z

Oh that was already merged @dhilst? Can you look at the comments? And maybe address in other PR?

dhilst · 2025-03-24T10:46:42Z

Oh that was already merged @dhilst? Can you look at the comments? And maybe address in other PR?

@viniciusferrao This was merged in another PR, not in the master, you can review the changes in that PR:

#95

@dhilst

* WIP: Repository class refactoring * Add parse() and unparse() methods, fix more things * Add stringstream read specialization, as suggested by @dhilst * Move some common functions to functions.h * Remove this-> * Fix repo class * Fix const ref and declaration name * Fix naming * Rename required files * fixup! Rename required files * WIP repositories class sketches * Make Cluster generic over Runner This commit adds a type parameter in Cluster class regarding the Runner. This is in an intetion to decouple cluster from the Runner in the near future. Then all these type parameters spreding all over the place can be removed Runner is a special case here, it what runs commands so I want to be very strict in where we can use it. Another thing to pay attention is that Cluster is a kind of "god" object where every other parts of the code rely into, we want to break this into smaller pieces and have the code depending on more atomic parts, this will help with testability. * Removing Runner from Cluster * Detach the presenter/view build from the rest of the code The intent is that this become an internal library in future Rationale: Having better separation of concerns and less coupling between some complex components (like the UI) from the remaining of the code. This may make the building faster on average aftewars. * WIP Refactoring RepoManager * Isolating Glib::KeyFile * Add name spaces and move files to their places I'm favoring to move stuff to models/ or services/ folders/namespaces. There is a lot of moves to do yet but this already outlines some structure * Refactoring RepoManager * Testing RepoManager refactoring * Run clang-format * Testing release build * Run clang-format again * Remove empty file * Remove commented code * Add RPMRepoManager sketch implementation * Replace old code with RPMRepositoryManager in repos.cpp * Remove unused code * Save RPMRepositoryFile only once for multiple enable calls * Run clang-format * RPM Build script && Use host glibmm (#96) * Add script to build rpms * Fix debug build * Link against host Glibmm using pkg-config * Extract glibmm from diskImage, move it to files.cpp --------- Co-authored-by: Daniel Hilst <daniel@versatushpc.com.br> * OFED doca + Revam repos + Remove deps (#97) * Adding OFED option and Cluster singleton with global getter * Add singleton class * Use Singleton<T> class for other singletons * Make all Dry Run message LOG_INFO * Remove print and test option * Implement DOCA kernel driver installation into the netboot image * Fix OFED installation in headnode * Fix review comments * Generalize testing and fix createHTTPRepo function * Remove CATTUS_... environment variables in favor of --force + --skip flags * Rename BaseRunner to IRunner for consistency * Wrap magic_enum lib * Remove package_manager in favor of IOSService interface * Deduplicate code * Run clang-format * Remove hwinfo, cloyster/hardware.h and tests The tests are breaking because of the refactoring, I'll redo the tests after I finish it * Remove inifile in favor of KeyFile * Removing old repository code * Add comments and FIXME * Use boost to parse options * Run clang-format * Decouple message bus from implementors * Fix test command handling * Fix warning in options.h * Restores runtime behavior after refactoring (WIP) * Replace boost::program_options with CLI11 * Implement repository sanity checking logic in repos.cpp * WIP generalizing repository addition * Restore testing code infra * Add test on the CI * Move singletons initalization to its own file * [WIP] Add libbacktrace to the dependencies * Decouple I/O from repository config classes to make them testable * Remove stacktrace attempt There is no libstdc++exp.a in Rocklinux repositories, stacktrace requires it. * Continuing the repositories core logic implementation * Remove old repository installation for xCAT and OFED * Add test files * Add ScriptBuilder service * Update NFS with script builder * Refactor NFS to use ScriptBuilder for installation and image customization. * WIP Fixing repositories bugs after the revamp * Fixing image generation and bugs after revamp * Fix the tests --------- Co-authored-by: Daniel Hilst <daniel@versatushpc.com.br> --------- Co-authored-by: Daniel Hilst <daniel@versatushpc.com.br> Co-authored-by: Daniel Hilst <danielhilst@gmail.com>

dhilst self-assigned this Feb 25, 2025

dhilst force-pushed the rpm-build branch 2 times, most recently from ac7d337 to 1521f2c Compare February 25, 2025 17:57

Add script to build rpms

e41f1ed

dhilst force-pushed the rpm-build branch from 1521f2c to e41f1ed Compare February 25, 2025 17:57

dhilst marked this pull request as ready for review February 25, 2025 18:00

dhilst marked this pull request as draft February 25, 2025 18:05

Fix debug build

6c0a74e

dhilst force-pushed the rpm-build branch from 997d33c to d666d09 Compare March 6, 2025 22:30

Link against host Glibmm using pkg-config

696a6e6

dhilst force-pushed the rpm-build branch from d666d09 to 696a6e6 Compare March 6, 2025 22:47

dhilst marked this pull request as ready for review March 7, 2025 18:16

dhilst changed the title ~~RPM Build script~~ RPM Build script && Use host glibmm Mar 7, 2025

Extract glibmm from diskImage, move it to files.cpp

7825697

dhilst force-pushed the rpm-build branch from a7890aa to 7825697 Compare March 7, 2025 18:33

dhilst merged commit ae1436e into repo-class Mar 17, 2025

viniciusferrao suggested changes Mar 21, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RPM Build script && Use host glibmm#96

RPM Build script && Use host glibmm#96
dhilst merged 4 commits intorepo-classfrom
rpm-build

dhilst commented Feb 25, 2025 •

edited

Loading

Uh oh!

sonarqubecloud Bot commented Mar 7, 2025

Uh oh!

dhilst commented Mar 17, 2025

Uh oh!

viniciusferrao Mar 13, 2025

Uh oh!

viniciusferrao Mar 21, 2025

Uh oh!

viniciusferrao Mar 21, 2025

Uh oh!

viniciusferrao commented Mar 21, 2025

Uh oh!

dhilst commented Mar 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants



		std::string checksum(const std::string& data);
		std::string checksum(const std::filesystem::path& path, const std::size_t chunkSize = 16384);

Conversation

dhilst commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud Bot commented Mar 7, 2025

Quality Gate passed

Uh oh!

dhilst commented Mar 17, 2025

Uh oh!

viniciusferrao Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

viniciusferrao Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

viniciusferrao Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

viniciusferrao commented Mar 21, 2025

Uh oh!

dhilst commented Mar 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dhilst commented Feb 25, 2025 •

edited

Loading