Skip to content

conf(ci): dont run on release branches - #38

Merged
vinpogo merged 3 commits into
mainfrom
conf/ci
Mar 2, 2026
Merged

conf(ci): dont run on release branches#38
vinpogo merged 3 commits into
mainfrom
conf/ci

Conversation

@vinpogo

@vinpogo vinpogo commented Mar 2, 2026

Copy link
Copy Markdown
Owner

No description provided.

@vinpogo
vinpogo marked this pull request as ready for review March 2, 2026 16:54
Copilot AI review requested due to automatic review settings March 2, 2026 16:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the CI workflow trigger to avoid running CI for certain branches, intended to reduce unnecessary CI runs around releases (Changesets release branches).

Changes:

  • Add pull_request.branches-ignore for changeset-release/* in CI workflow.
Comments suppressed due to low confidence (1)

.github/workflows/ci.yml:4

  • pull_request.branches-ignore filters by the PR base branch, not the source (head_ref). Changesets release PRs are typically opened from changeset-release/* into main, so CI will still run and this won't achieve “don’t run on release branches”. If the intent is to skip CI for release PRs, add a job-level condition (e.g., jobs.ci.if checking github.head_ref / github.event.pull_request.head.ref) instead of (or in addition to) branches-ignore.
  pull_request:
    branches-ignore:
      - 'changeset-release/*'

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/ci.yml
push:
branches-ignore:
- 'main'
- 'changeset-release/*'

Copilot AI Mar 2, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching the workflow trigger from pull_request to push means CI will no longer run on PRs (including PRs from forks), so required checks may never execute before merge. If the intent is only to skip release branches, keep a pull_request trigger (optionally with branches-ignore: ['changeset-release/*']) and/or scope the push trigger to the branches you actually want, rather than removing PR events entirely.

Suggested change
- 'changeset-release/*'
- 'changeset-release/*'
pull_request:
branches-ignore:
- 'changeset-release/*'

Copilot uses AI. Check for mistakes.
@vinpogo
vinpogo merged commit 468b6d2 into main Mar 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants