Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts the CI workflow trigger to avoid running CI for certain branches, intended to reduce unnecessary CI runs around releases (Changesets release branches).
Changes:
- Add
pull_request.branches-ignoreforchangeset-release/*in CI workflow.
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:4
pull_request.branches-ignorefilters by the PR base branch, not the source (head_ref). Changesets release PRs are typically opened fromchangeset-release/*intomain, so CI will still run and this won't achieve “don’t run on release branches”. If the intent is to skip CI for release PRs, add a job-level condition (e.g.,jobs.ci.ifcheckinggithub.head_ref/github.event.pull_request.head.ref) instead of (or in addition to)branches-ignore.
pull_request:
branches-ignore:
- 'changeset-release/*'
| push: | ||
| branches-ignore: | ||
| - 'main' | ||
| - 'changeset-release/*' |
There was a problem hiding this comment.
Switching the workflow trigger from pull_request to push means CI will no longer run on PRs (including PRs from forks), so required checks may never execute before merge. If the intent is only to skip release branches, keep a pull_request trigger (optionally with branches-ignore: ['changeset-release/*']) and/or scope the push trigger to the branches you actually want, rather than removing PR events entirely.
Suggested change
| - 'changeset-release/*' | |
| - 'changeset-release/*' | |
| pull_request: | |
| branches-ignore: | |
| - 'changeset-release/*' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.