chore: update publish workflow #213
Merged
alisonferreira-vnt merged 2 commits intomainfrom Jan 26, 2026
Merged
Conversation
…d npm for frontend
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the publish GitHub Actions workflow to install Python tooling via pipx and switch the frontend pipeline from pnpm to npm, with minor formatting cleanup. Flow diagram for updated publish GitHub Actions workflowflowchart TD
trigger[on release or workflow_dispatch]
subgraph job_python[Job publish_python]
A1[Checkout code]
A2[Set up Python 3.12]
A3[Install pipx via apt]
A4[Run pipx ensurepath]
A5[Install poetry 1.8.5 with pipx]
A6[poetry install --with dev]
A7[Build Python package]
A8[Publish to PyPI]
end
subgraph job_frontend[Job publish_frontend]
B1[Checkout code]
B2[Set up Node.js 22]
B3[npm install in frontend]
B4[npm run build in frontend]
B5[npm publish --no-git-checks]
end
trigger --> job_python
trigger --> job_frontend
A1 --> A2 --> A3 --> A4 --> A5 --> A6 --> A7 --> A8
B1 --> B2 --> B3 --> B4 --> B5
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
=======================================
Coverage 93.85% 93.85%
=======================================
Files 19 19
Lines 700 700
Branches 51 51
=======================================
Hits 657 657
Misses 33 33
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The
sudo apt install pipxstep may block on interactive prompts in CI; consider usingsudo apt-get update && sudo apt-get install -y pipx(or leveraging the preinstalled pipx on GitHub runners) to ensure non-interactive execution. pipx ensurepathupdates the shell configuration but won’t affect the current job’s PATH in that step; you may want to either rely on the system pipx path or explicitly add the pipx bin directory to PATH before invokingpoetry.npm publish --no-git-checksuses a pnpm-specific flag that npm does not support; update this command or its options to use flags that are valid for npm.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `sudo apt install pipx` step may block on interactive prompts in CI; consider using `sudo apt-get update && sudo apt-get install -y pipx` (or leveraging the preinstalled pipx on GitHub runners) to ensure non-interactive execution.
- `pipx ensurepath` updates the shell configuration but won’t affect the current job’s PATH in that step; you may want to either rely on the system pipx path or explicitly add the pipx bin directory to PATH before invoking `poetry`.
- `npm publish --no-git-checks` uses a pnpm-specific flag that npm does not support; update this command or its options to use flags that are valid for npm.
## Individual Comments
### Comment 1
<location> `.github/workflows/publish.yml:74` </location>
<code_context>
working-directory: ./frontend
run: |
- pnpm publish --no-git-checks
+ npm publish --no-git-checks
</code_context>
<issue_to_address>
**issue (bug_risk):** `--no-git-checks` is not a valid npm flag and will cause the publish step to fail.
This flag is pnpm-specific and will cause `npm publish` to fail with an unknown option error. For npm, remove the flag or configure the desired git-check behavior via npm config or environment instead.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update publish workflow to use pipx for Python dependencies and npm for frontend
Summary by Sourcery
Update the publish workflow to use pipx-managed Poetry for Python packaging and npm for frontend build and publish steps instead of pnpm.
Build: