Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Use ruby rspec convention in group spec #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iamjarvo
Copy link
Contributor

Use rspecisms

I would have liked to take this refactor further but still exploring how vinyl works.

➜ ~/c/vinyldns-ruby git:(rspec-group-spec) ✗ bundle exec rspec spec/group_spec.rb

Vinyldns::API::Group
  .create
    can POST & receives 409 Conflict connecting to an already existing group
  .update
    can PUT & receives 400 Bad Request with "Missing Group"
    raises error when request_params argument is not hash
  .get
    does not raise an error
  .list_my_groups
    does not raise an error
    returns something
  .list_group_admins
    does not raise an error
  .list_group_members
    does not raise an error
  .get_group_activity
    does not raise an error

Finished in 4.49 seconds (files took 0.39254 seconds to load)
9 examples, 0 failures

@britneywright
Copy link
Contributor

Thanks for the contribution. We need to look into the Travis CI failure.

@NorseGaud NorseGaud self-assigned this Nov 12, 2018
@NorseGaud
Copy link
Contributor

Travis was never fully set up. Your changes are great, so I'll check this in once I get Travis working.

@iamjarvo
Copy link
Contributor Author

@NorseGaud I have some ideas on running the tests on travis. If you haven't started work I'd like to give it a shot.

@NorseGaud
Copy link
Contributor

Sounds good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants