Making reporters plugin aware #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArquintL
reviewed
Mar 18, 2025
Co-authored-by: Linard Arquint <[email protected]>
Co-authored-by: Linard Arquint <[email protected]>
Co-authored-by: Linard Arquint <[email protected]>
ArquintL
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new trait
PluginAwareReporterand modifying all existingReporterimplementations to implement it.The
SilFrontend, when given aPluginAwareReporter, informs it about the current plugins s.t. the reporter can let the plugins transformEntitySuccessMessages andEntityFailureMessages. Currently, these are not being transformed at all, which is why entity messages can report incorrect results.The
ActorReporterin ViperServer will have to be modified to implement the new trait as well.