Remove deprecated usage of setUserData.#1502
Merged
Merged
Conversation
daleglass
added
enhancement
|
The following links are available: build (ubuntu-18.04, full)
build (macOS-10.15, full) build (windows-latest, full) |
Member
|
Needs testing by someone in VR. :) |
Contributor
|
I just tested it in VR, especially with the tablet. Works perfectly fine. |
digisomni
changed the title
digisomni
added
QA Approved
Member
|
This should be ready for review after 1485 is merged. |
daleglass
force-pushed
the
qt5-fix-userdata
branch
from
a0ba291 to
b8045b0
Compare
|
The following links are available: build (macOS-10.15, full) build (ubuntu-18.04, full)
build (windows-latest, full) build (self-hosted_debian-11_aarch64, full)
|
ctrlaltdavid
requested changes
Jan 17, 2022
ctrlaltdavid
left a comment
ctrlaltdavid
left a comment
Collaborator
There was a problem hiding this comment.
Needs updating with PR #1485 changes once that PR is merged.
This removes the usage of QObjectUserData, setUserData and userData. Fixes vircadia#1305
daleglass
force-pushed
the
qt5-fix-userdata
branch
from
b8045b0 to
27ddd1d
Compare
ctrlaltdavid
approved these changes
Jan 20, 2022
ctrlaltdavid
added
CR Approved
|
The following links are available: build (ubuntu-18.04, full)
build (macOS-10.15, full) build (windows-latest, full) build (self-hosted_debian-11_aarch64, full)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the usage of QObjectUserData, setUserData and userData.
The actual change is minor but this required rearranging things a bit. MenuUserData class is now declared in the header so that the Q_OBJECT macro is processed properly.
Fixes #1305
Builds on top of #1485