Fix dedicated IPFS gateway rejecting download requests.#1589
Merged
Conversation
it requires a browser like user agent header, probably due to cloudflare protection.
|
The following links are available: build (ubuntu-18.04, full)
build (macOS-10.15, full) build (windows-latest, full) build (self-hosted_debian-11_aarch64, full)
|
digisomni
changed the title
digisomni
added
bugfix
needs CR (code review)
CR Approved
digisomni
approved these changes
Feb 2, 2022
Contributor
|
This one is weird, why is SSL not present in Python on OSX? Pretty much everything uses SSL these days, and many servers are SSL exclusive. |
Contributor
Author
|
I'm not sure myself, that logic has been there since forever it seems, I just rearranged some things, but didn't change anything on that regard, just added the user agent header. It might not be an issue anymore or maybe another quirk of this low level API, pretty much nobody recommends using it anymore as far as I can tell. |
daleglass
approved these changes
Feb 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a newer, higher level officially recommended python requests library that can take care of all this mess, but I'm not sure if it's ok to introduce it here as a dependency.