Update API documentation for Window.prompt().#1597
Merged
Conversation
Documentation for Window.prompt() states that if the user click "Cancel" it will return "" It does, in fact return null, I don't know if that is intentional but arguments could be made for both. This just updates the documentation and the example .
digisomni
added
CR Approved
digisomni
changed the title
digisomni
changed the title
digisomni
approved these changes
Feb 13, 2022
digisomni
left a comment
digisomni
left a comment
Member
There was a problem hiding this comment.
Just tested it and that indeed seems to be the case, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation for
Window.prompt()states that if the user click "Cancel" it will return""It does, in fact return
null, I don't know if that is intentional but arguments could be made for both.This just updates the documentation and the example .