Skip to content

Build-YubiKeyPIVCertificateSigningRequest changes #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
virot merged 3 commits into from
Mar 23, 2025
Merged

Build-YubiKeyPIVCertificateSigningRequest changes #147

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
406cc7c
CSR requires 5.3.0 to get metadata
virot Mar 21, 2025
32f3bb7
Build-YubiKeyPIVCertificateSigningRequest should return a System.Secu…
virot Mar 23, 2025
522c9e8
Lint fix
virot Mar 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions Module/Cmdlets/PIV/BuildYubiKeyPIVCertificateSigningRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,13 @@ protected override void ProcessRecord()
CertificateRequest request;
X509SignatureGenerator signer;

// get the metadata catch if fails
// This is only supported on firmware 5.3.0 and newer.
if (((YubiKeyDevice)YubiKeyModule._yubikey!).FirmwareVersion < new FirmwareVersion(5, 3, 0))
{
throw new NotSupportedException("This feature requires firmware version 5.3.0 or newer.");
}

// get the metadata catch if fails
PivMetadata? metadata = null;
PivPublicKey? publicKey = null;
try
Expand Down Expand Up @@ -162,7 +168,8 @@ protected override void ProcessRecord()
}
else
{
WriteObject(requestSigned);
var csrObject = CertificateRequest.LoadSigningRequestPem(pemData.AsSpan(), HashAlgorithm, CertificateRequestLoadOptions.UnsafeLoadCertificateExtensions);
WriteObject(csrObject);
}
}
WriteDebug("ProcessRecord in New-YubikeyPIVCSR");
Expand Down