Skip to content

[CI-NO-BUILD] [viostor] Increase MAX_PHYS_SEGMENTS limit #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[CI-NO-BUILD] [viostor] Increase MAX_PHYS_SEGMENTS limit #1315

wants to merge 1 commit into from

Conversation

benyamin-codez
Copy link
Contributor

Changes the MAX_PHYS_SEGMENTS limit to 1,024 equal to QEMU's VIRTQUEUE_MAX_SIZE.

This results in:

  1. adaptExt->max_segments = 1024
  2. ConfigInfo->NumberOfPhysicalBreaks = 1025
  3. ConfigInfo->MaximumTransferLength = 4MiB (1,024 * PAGE_SIZE = 4,096KiB)

@benyamin-codez
[viostor] Increase MAX_PHYS_SEGMENTS limit
dfafc22 
Changes the MAX_PHYS_SEGMENTS limit to 1,024 equal to QEMU's VIRTQUEUE_MAX_SIZE.

This results in:
1. adaptExt->max_segments = 1024
2. ConfigInfo->NumberOfPhysicalBreaks = 1025
3. ConfigInfo->MaximumTransferLength = 4MiB (1,024 * PAGE_SIZE = 4,096KiB)

Signed-off-by: benyamin-codez <[email protected]>
@benyamin-codez
Copy link
Contributor Author

I wouldn't much care to attempt merging this until after the following PRs merge:

#1289
#1295
#1297
#1298
#1299
#1304

Here is a pic showing the VQ Buffer Length and SRB DataTransferLength at the tail end of a 4MiB sequential read:

viostor_4M_MaxXferLen_tailend

This was referenced Feb 26, 2025
Open
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrozenfe vrozenfe Awaiting requested review from vrozenfe vrozenfe will be requested when the pull request is marked ready for review vrozenfe is a code owner

@YanVugenfirer YanVugenfirer Awaiting requested review from YanVugenfirer YanVugenfirer will be requested when the pull request is marked ready for review YanVugenfirer is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@benyamin-codez