Skip to content

Hck rss bsod work in progress #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 27 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
8f385f5
netkvm: move all NBLs drop to separate procedure
ybendito Mar 21, 2025
37aed71
netkvm: drop all the NBLs on carrier loss
ybendito Mar 21, 2025
8fa55ef
netkvm: simplify TX code for case of single queue
ybendito Mar 22, 2025
f8aa83d
netkvm: add debug printout in send path
ybendito Mar 22, 2025
42722f7
netkvm: fix broken compilation with history log
ybendito Mar 30, 2025
c850c5c
netkvm: track last tx completion time per queue
ybendito Mar 23, 2025
2dbfe47
netkvm: add public method for getting ref count
ybendito Mar 26, 2025
87c7d3d
netkvm: maintain NBL chain information
ybendito Mar 22, 2025
c21810c
netkvm: remove unneeded procedure
ybendito Apr 7, 2025
8498ea9
netkvm: preserve per-connection chains
ybendito Mar 22, 2025
4f54424
netkvm: add history logs for NBL-related operations
ybendito Mar 30, 2025
1a0a550
netkvm-dumpparser: fix build and update
ybendito Mar 26, 2025
0cb024d
netkvm-dumpparser: parse history data only
ybendito Mar 29, 2025
f378d0f
not for delivery: use performance counter for timestamps
ybendito Mar 23, 2025
a1f5542
netkvm: optionally keep the NBL history in the CNBL
ybendito Mar 28, 2025
f7f42c9
wip Die
ybendito Mar 26, 2025
6dd6d41
netkvm: add CNBL getter for m_NBL
ybendito Apr 5, 2025
8a28663
netkvm: emit debug history with queue index
ybendito Apr 5, 2025
69af2e6
netkvm: emit debug history for chained NBLs with queue index
ybendito Apr 5, 2025
27de6a4
netkvm: remember serial number in chain inside CNBL
ybendito Apr 5, 2025
653784e
netkvm: take care of mapping failure case
ybendito Apr 5, 2025
3805b40
netkvm: do not invert order of NBLs on completion
ybendito Apr 5, 2025
febd004
netkvm: do not change the order of CNBLs after sending
ybendito Apr 7, 2025
0dc95e7
netkvm: recreate the NBL chain on CNBL completion
ybendito Apr 7, 2025
e1e0236
wip fire dpc
ybendito Apr 7, 2025
c2d4571
not sure - additional poll request
ybendito Apr 7, 2025
3529450
fix dump parser
ybendito Apr 7, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NetKVM/Common/ParaNdis_TX.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -517,8 +517,10 @@ void CParaNdisTX::NBLMappingDone(CNBL *NBLHolder)
}
else
{
DPrintf(0, "[%s] ERROR: one or more NBs failed to be mapped!\n", __FUNCTION__);
NBLHolder->SetStatus(NDIS_STATUS_FAILURE);
// this is ok if this CNBL is not first one
m_Context->Statistics.ifOutErrors += NBLHolder->NumberOfBuffers();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW: For the acadenic interest, do you see this in practice? When?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, just to handle the error path and give some visibility in case it happens.

NBLHolder->UnsetInChain();
NBLHolder->Release();
}
Expand Down