[RHEL-22354] Completion of NBL chains #1346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new logic to support chains is placed under ifdef currently
and the driver works in backward compatible mode when all the
procedures related to chain information in the NBL are stubs.
The new logic that takes in account NBL chain is:
For single NBL (not chained) - all 3 fields in m_Chain are 0.
For first NBL in chain:
m_FirstInChain = 0
m_NumChained is number of NBLs following the first one
m_NumCompleted is incremented on each NBL completion
For following NBLs in chain:
m_FirstInChain is CNBL with first NBL
m_NumChained is serial number in chain
m_NumCompleted is not used (0)
Each chained CNBL before mapping AddRef's the first one on
creation and Release's it in destructor, so lifetime of
the first CNBL is alive till one or more of chained ones
alive.
The condition when the CNBL is done and can be released and
completed:
Single NBL - as before (all NBs are completed)
First in chain - the same and all the chained NBLs are done
Chained - the same and the first one is done
Such a way, all the CNBLs for chained NBLs become 'done' at the
same moment
Signed-off-by: Yuri Benditovich <[email protected]>
Signed-off-by: Yuri Benditovich <[email protected]>
Connection is src:dest IP addresses and ports, so for all the packets sent to specific connection the hash should be the same. We collect NBL chain till all the indirection indices are the same, then flush the chain to the TX queue and start a new chain. Signed-off-by: Yuri Benditovich <[email protected]>
Signed-off-by: Yuri Benditovich <[email protected]>
Chain NBLs from the list of completed CNBLs as they appear in the list and do not invert them. Later we're going to add NBL chains from the 'first in chain' CNBLs. Signed-off-by: Yuri Benditovich <[email protected]>
Keep the order of NBLs wherever possible, i.e. push them at the end of waiting list and then process waiting list and remove from it all the completed NBLs, so that earlier NBLs are removed first. Signed-off-by: Yuri Benditovich <[email protected]>
Jira link: https://issues.redhat.com/browse/RHEL-22354 See also: https://issues.redhat.com/browse/RHEL-85605 The NBL chain support is still disabled but the code for it is functional. What it does if we enable it: Deliver entire NBL chain if one was provided in Send() call. Each CNBL created for each 'next' NBL (following to the first one) on completion of all it's NBs detaches it's NBL and attaches it to the m_NBL of the first one. Such a way when all the CNBLs related to the same chain are ready, only first one has m_NBL (with all the rest of NBLs chained to it). For all the rest of CNBLs the m_NBL is NULL. The order of NBLs in the chain might be slightly different than original one (due to NB completions running simultaneously in different flows), for that the chain is tested and repaired if needed before it is indicated up. Signed-off-by: Yuri Benditovich <[email protected]>
Jira link: https://issues.redhat.com/browse/RHEL-22354 See also: https://issues.redhat.com/browse/RHEL-85605 Enable NBL chain processing. See previous commit for technical details. If in future for any purpose there is a need to disable this functionality completely, it is enough to define NBL_CHAINS as 0, then each CNBL is independent and the way code works is backward-compatible. Signed-off-by: Yuri Benditovich <[email protected]>
|
Win11 - 3 failures: IMO, can be merged. |
| bool HaveDetachedBuffers() | ||
| { | ||
| return m_MappedBuffersDetached != 0; | ||
| } |
| @@ -446,18 +446,37 @@ static VOID ParaNdis6_SendNetBufferLists(NDIS_HANDLE miniportAdapterContext, | |||
| } | |||
| #ifdef PARANDIS_SUPPORT_RSS | |||
| CNdisPassiveReadAutoLock autoLock(pContext->RSSParameters.rwLock); | |||
| if (pContext->nPathBundles > 1 && pContext->RSS2QueueMap != nullptr) | |||
| auto queueMap = pContext->RSS2QueueMap; | |||
| @@ -574,6 +593,13 @@ void CNBL::NBComplete() | |||
| m_MappedBuffersDetached.Release(); | |||
| if (m_BuffersDone.AddRef() == (LONG)m_BuffersNumber) | |||
| { | |||
| AddHistory(__FUNCTION__, "", "", NULL, "Buffers", m_BuffersNumber); | |||
| ParaNdis_DebugHistory(this, | |||
| @@ -705,8 +706,12 @@ PNET_BUFFER_LIST CParaNdisTX::ProcessWaitingList(CRawCNBLList &completed) | |||
| NBL->Release(); | |||
| if (CallCompletionForNBL(m_Context, RawNBL)) | |||
| { | |||
| NET_BUFFER_LIST_NEXT_NBL(RawNBL) = CompletedNBLs; | |||
| CompletedNBLs = RawNBL; | |||
| *tail = RawNBL; | |||
| @@ -691,8 +691,7 @@ PNET_BUFFER_LIST CParaNdisTX::ProcessWaitingList(CRawCNBLList &completed) | |||
| { | |||
| TDPCSpinLocker LockedContext(m_WaitingListLock); | |||
|
|
|||
| completed.ForEachDetachedIf([](CNBL *NBL) { return !NBL->IsSendDone(); }, | |||
| [&](CNBL *NBL) { m_WaitingList.PushBack(NBL); }); | |||
| completed.ForEachDetached([&](CNBL *NBL) { m_WaitingList.PushBack(NBL); }); | |||
YanVugenfirer
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.