Added support for providing Log Analytics Id and Key, and Custom columns in the pod spec#352
Open
pvashisht888 wants to merge 3 commits intovirtual-kubelet:masterfrom
Open
Added support for providing Log Analytics Id and Key, and Custom columns in the pod spec#352pvashisht888 wants to merge 3 commits intovirtual-kubelet:masterfrom
pvashisht888 wants to merge 3 commits intovirtual-kubelet:masterfrom
Conversation
pvashisht888
commented
Nov 2, 2022
- Added a CA cert env var so that we can see logs through kubectl for a pod running in ACI.
- Added a new extension for CustomLogger so that logs can be seen in a Log Analytics workspace for a CG running in ACI through the virtual kubelet. The LA Id and Key is provided through the annotations in the pod spec.
- Added support for showing custom columns in Log Analytics workspace for a CG running in ACI through the virtual kubelet. These custom columns (and their values) are also provided in the pod spec as an annotation which are then parsed and supplied to the custom logger extension. These columns (and their values) are visible in ContainerAppConsoleLogs_CL table in the Log Analytics workspace.
Codecov Report
@@ Coverage Diff @@
## master #352 +/- ##
==========================================
+ Coverage 44.65% 45.41% +0.75%
==========================================
Files 46 46
Lines 5860 5919 +59
==========================================
+ Hits 2617 2688 +71
+ Misses 2992 2979 -13
- Partials 251 252 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.