Skip to content

Move HorizonGraphLayer into infovis-layers#268

Merged
georgioskarnas merged 1 commit into
masterfrom
mhhho8-codex/move-horizon-layers-to-infovis-layers
Jul 8, 2025
Merged

Move HorizonGraphLayer into infovis-layers#268
georgioskarnas merged 1 commit into
masterfrom
mhhho8-codex/move-horizon-layers-to-infovis-layers

Conversation

@kargeor
Copy link
Copy Markdown
Collaborator

@kargeor kargeor commented Jul 8, 2025

Summary

  • move HorizonGraphLayer implementation under modules/infovis-layers
  • export HorizonGraphLayer and MultiHorizonGraphLayer from infovis-layers
  • remove HorizonGraphLayer exports from layers
  • update example to use new package
  • update documentation and sidebar
  • fix TypeScript path mapping

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR relocates the HorizonGraphLayer implementations into the infovis-layers package, updates exports and paths, and adjusts examples and docs accordingly.

  • Removes HorizonGraphLayer exports from modules/layers and re-exports them from modules/infovis-layers
  • Updates example dependency and import paths to @deck.gl-community/infovis-layers
  • Updates documentation sidebar and API reference import paths and source links

Reviewed Changes

Copilot reviewed 7 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
modules/layers/src/index.ts Removed HorizonGraphLayer and MultiHorizonGraphLayer exports
modules/infovis-layers/src/index.ts Added HorizonGraphLayer and MultiHorizonGraphLayer exports
examples/layers/horizon-graph-layer/package.json Switched dependency to @deck.gl-community/infovis-layers
examples/layers/horizon-graph-layer/app.tsx Updated import path to infovis-layers
docs/modules/infovis-layers/sidebar.json Added HorizonGraphLayer and MultiHorizonGraphLayer to sidebar
docs/modules/infovis-layers/api-reference/horizon-graph-layer.md Updated import path and source link
docs/modules/infovis-layers/api-reference/multi-horizon-graph-layer.md Updated import path and source link
Comments suppressed due to low confidence (4)

docs/modules/infovis-layers/api-reference/multi-horizon-graph-layer.md:59

  • [nitpick] Consider linking directly to the specific multi-horizon-graph-layer source file (e.g., /horizon-graph-layer/multi-horizon-graph-layer.ts) for clearer navigation.
[modules/infovis-layers/src/layers/horizon-graph-layer](https://github.com/visgl/deck.gl/tree/master/modules/infovis-layers/src/layers/horizon-graph-layer)

docs/modules/infovis-layers/api-reference/horizon-graph-layer.md:46

  • [nitpick] It may be more precise to link directly to the horizon-graph-layer.ts file within the folder to help readers find the implementation faster.
[modules/infovis-layers/src/layers/horizon-graph-layer](https://github.com/visgl/deck.gl/tree/master/modules/infovis-layers/src/layers/horizon-graph-layer)

modules/infovis-layers/src/index.ts:8

  • Add unit tests to verify that HorizonGraphLayer and MultiHorizonGraphLayer are correctly exported and that their basic rendering logic functions as expected.
export type {HorizonGraphLayerProps} from './layers/horizon-graph-layer/horizon-graph-layer';

examples/layers/horizon-graph-layer/app.tsx:11

  • [nitpick] Consider adding a small example of the single HorizonGraphLayer alongside MultiHorizonGraphLayer to demonstrate both use cases in this sample app.
import {MultiHorizonGraphLayer} from '@deck.gl-community/infovis-layers';

@kargeor kargeor force-pushed the mhhho8-codex/move-horizon-layers-to-infovis-layers branch 2 times, most recently from 61dffc5 to 4ebe43f Compare July 8, 2025 17:26
@kargeor kargeor force-pushed the mhhho8-codex/move-horizon-layers-to-infovis-layers branch from 4ebe43f to 284bd33 Compare July 8, 2025 17:27
@georgioskarnas georgioskarnas merged commit 8bf71ed into master Jul 8, 2025
1 check passed
@georgioskarnas georgioskarnas deleted the mhhho8-codex/move-horizon-layers-to-infovis-layers branch July 8, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants