Move HorizonGraphLayer into infovis-layers#268
Merged
georgioskarnas merged 1 commit intoJul 8, 2025
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR relocates the HorizonGraphLayer implementations into the infovis-layers package, updates exports and paths, and adjusts examples and docs accordingly.
- Removes HorizonGraphLayer exports from
modules/layersand re-exports them frommodules/infovis-layers - Updates example dependency and import paths to
@deck.gl-community/infovis-layers - Updates documentation sidebar and API reference import paths and source links
Reviewed Changes
Copilot reviewed 7 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| modules/layers/src/index.ts | Removed HorizonGraphLayer and MultiHorizonGraphLayer exports |
| modules/infovis-layers/src/index.ts | Added HorizonGraphLayer and MultiHorizonGraphLayer exports |
| examples/layers/horizon-graph-layer/package.json | Switched dependency to @deck.gl-community/infovis-layers |
| examples/layers/horizon-graph-layer/app.tsx | Updated import path to infovis-layers |
| docs/modules/infovis-layers/sidebar.json | Added HorizonGraphLayer and MultiHorizonGraphLayer to sidebar |
| docs/modules/infovis-layers/api-reference/horizon-graph-layer.md | Updated import path and source link |
| docs/modules/infovis-layers/api-reference/multi-horizon-graph-layer.md | Updated import path and source link |
Comments suppressed due to low confidence (4)
docs/modules/infovis-layers/api-reference/multi-horizon-graph-layer.md:59
- [nitpick] Consider linking directly to the specific
multi-horizon-graph-layersource file (e.g.,/horizon-graph-layer/multi-horizon-graph-layer.ts) for clearer navigation.
[modules/infovis-layers/src/layers/horizon-graph-layer](https://github.com/visgl/deck.gl/tree/master/modules/infovis-layers/src/layers/horizon-graph-layer)
docs/modules/infovis-layers/api-reference/horizon-graph-layer.md:46
- [nitpick] It may be more precise to link directly to the
horizon-graph-layer.tsfile within the folder to help readers find the implementation faster.
[modules/infovis-layers/src/layers/horizon-graph-layer](https://github.com/visgl/deck.gl/tree/master/modules/infovis-layers/src/layers/horizon-graph-layer)
modules/infovis-layers/src/index.ts:8
- Add unit tests to verify that
HorizonGraphLayerandMultiHorizonGraphLayerare correctly exported and that their basic rendering logic functions as expected.
export type {HorizonGraphLayerProps} from './layers/horizon-graph-layer/horizon-graph-layer';
examples/layers/horizon-graph-layer/app.tsx:11
- [nitpick] Consider adding a small example of the single
HorizonGraphLayeralongsideMultiHorizonGraphLayerto demonstrate both use cases in this sample app.
import {MultiHorizonGraphLayer} from '@deck.gl-community/infovis-layers';
61dffc5 to
4ebe43f
Compare
4ebe43f to
284bd33
Compare
ibgreen-openai
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
modules/infovis-layersinfovis-layerslayers