fix(core): use correct mjolnir requireFailure key for recognizers

[charlieforward9]

Summary

Fixes Deck’s mjolnir recognizer setup so requireFailure relationships are actually passed to EventManager.

Problem

Deck normalized recognizer tuples using requestFailure, but mjolnir reads requireFailure. The typo silently dropped the failure dependencies declared in RECOGNIZERS, so gestures such as two-finger pitch could be beaten by pinch recognition on touch devices.

Change

• Rename the normalized tuple key from requestFailure to requireFailure.
• Add regression coverage that constructs a Deck and verifies pinch, pan, and click have the expected blocking recognizers in mjolnir’s requireFail arrays.

Validation

• Hand-tested on iOS WKWebView with GlobeController: two-finger vertical drag now pitches instead of being interpreted as a pinch/pan wobble.
• CI is green on the PR.

Merge Notes

Approved. Reviewer-requested regression coverage was added in follow-up commit b8f30a09.

[coveralls]

coverage: 83.386% (-0.004%) from 83.39% — NEW-HEAT:fix/recognizer-require-failure-typo into visgl:master

[chrisgervang]

I'm surprised this wasn't caught by typescript on the EventManager's recognizers param. Can that type need to be improved?

[charlieforward9]

Re: the TypeScript question — agreed, the type RecognizerTuple in mjolnir.js doesn't catch this because:

1. RecognizerTupleNormalized is part of a union (Recognizer | RecognizerConstructor | RecognizerTupleNormalized | [...]). When TypeScript checks an object literal against a union it only requires one branch to be assignable, and the excess-property check only fires when the literal's required keys are a strict subset of that branch. requireFailure and recognizeWith are both optional, so the object literal {recognizer, recognizeWith, requestFailure} matched RecognizerTupleNormalized (only recognizer was required) and the extra requestFailure was tolerated.
2. RecognizerTupleNormalized itself isn't exported from mjolnir.js, so consumers can't satisfies-pin it locally either.

Two tightening options, neither in scope here but I'm happy to follow up:

• Export RecognizerTupleNormalized from mjolnir.js's public types and add satisfies RecognizerTupleNormalized here. Local change, catches typos in this call site only.
• Make the RecognizerTuple union's normalized branch exact (e.g. require all three keys, with recognizeWith?: undefined / requireFailure?: undefined made non-optional-but-nullable). Catches typos everywhere but is a breaking change to mjolnir's public type.

Want me to open a follow-up PR for either?

[chrisgervang]

I would like for some coverage in this PR so that the regression doesn't come back again. It could be a test if types can't cover it

[charlieforward9]

Added in 725e724 — regression test asserts pinch/pan/click each have the right blocking recognizer in their mjolnir requireFail array.