Skip to content

Fix type hint of useDevicePixels to allow number input #9826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2025
Merged

Fix type hint of useDevicePixels to allow number input #9826

merged 1 commit into from
Oct 16, 2025

Conversation

@kylebarron
Copy link
Collaborator

Closes #

Background

The type hint of useDevicePixels currently only allows boolean, but the docs say number is also allowed

image

Change List

@coveralls
Copy link

Coverage Status

coverage: 91.144%. remained the same
when pulling b3fae22 on kyle/use-device-pixels-type
into 5da7942 on master.

@felixpalmer felixpalmer merged commit 72c7749 into master Oct 16, 2025
5 checks passed
@felixpalmer felixpalmer deleted the kyle/use-device-pixels-type branch October 16, 2025 16:29
felixpalmer pushed a commit that referenced this pull request Oct 16, 2025
@kylebarron @felixpalmer
Fix type hint of useDevicePixels to allow number input (#9826)
f07cbbf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pessimistress Pessimistress Pessimistress approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kylebarron @coveralls @Pessimistress @felixpalmer