fix(worldview) montage requires preview size to match resolution #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgervang
reviewed
Nov 5, 2021
| updateTimeCursor={timeMs => dispatch(updateTimeCursor(timeMs))} | ||
| debug={debug} | ||
| viewportMinAxis={viewportMinAxis} | ||
| viewportMinAxis={Math.min(resolution.width, resolution.height)} |
There was a problem hiding this comment.
Can we make this so that if the viewportMinAxis prop is provided it uses that, otherwise does this? There are situations where either is used.
| const canvasClientSize = getCanvasClientSize(resolution, viewportMinAxis); | ||
| // canvasClientSize * scalar = previewSize | ||
| const scalar = scale(previewSize, canvasClientSize); | ||
| // const scalar = scale(previewSize, canvasClientSize); |
There was a problem hiding this comment.
Since this only needs to be disabled for mapbox 2.5, but could still be used with 2.4 - can you treat previewSize as optional, where if it's provided then it should do this scaling and size the CSS container variable using previewSize. Otherwise (in the 2.5 case), don't scale and actually set the container size using the canvasSize variable?
chrisgervang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mapbox-glversion to 2.5.1 to fix white border lines that appear sometimes when rendering an image due to rounding issue. Transform is disabled to mitigate a bug introduced by 2.5.1 which results in misalignment between layers