fix(core): apply drawing buffer resize immediately for WebGL#2504
Draft
nokonoko1203 wants to merge 1 commit intovisgl:masterfrom
Draft
fix(core): apply drawing buffer resize immediately for WebGL#2504nokonoko1203 wants to merge 1 commit intovisgl:masterfrom
nokonoko1203 wants to merge 1 commit intovisgl:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Commit 939287e ("Fix flicker when resizing CanvasContext") deferred the actual canvas resize from
setDrawingBufferSize()togetCurrentFramebuffer()to avoid flicker caused by clearing the drawing buffer on resize.However, on WebGL this deferred resize never fires. When
beginRenderPass({framebuffer: null})is called, the two backends behave differently.WebGPU (
webgpu-render-pass.ts) — callsgetCurrentFramebuffer():WebGL (webgl-render-pass.ts) — only calls getDrawingBufferSize():
As a result, on WebGL canvas.width/canvas.height are never updated from their initial values, while drawingBufferWidth/drawingBufferHeight are correctly set by ResizeObserver. The viewport is set to the intended size but the actual drawing buffer remains at the initial canvas size, causing a resolution mismatch.
Change List