Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mutual funds trades tracking #16

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

vishwamartur
Copy link
Owner

@vishwamartur vishwamartur commented Nov 25, 2024

Related to #8

Add real-time mutual funds trades tracking functionality.

  • New File: data/mutual_funds_tracker.py

    • Define MutualFundsTracker class to handle real-time tracking of mutual funds trades.
    • Implement fetch_mutual_funds_trades method to fetch real-time mutual funds trades data.
    • Implement process_mutual_funds_trades method to process mutual funds trades data.
  • Update main.py

    • Import MutualFundsTracker from data/mutual_funds_tracker.
    • Initialize MutualFundsTracker in the main function.
    • Add mutual_funds_tracker to the process_market_data function parameters.
    • Create a task to process mutual funds trades in process_market_data function.
  • Update config/config.py

    • Add mutual_funds_tracking_enabled and mutual_funds_data_source settings under investment_banking section.
  • Update config/api_config.py

    • Add mutual_funds_api_key and mutual_funds_api_endpoint settings.
    • Add mutual_funds_headers method to return headers for Mutual Funds API.
    • Add get_mutual_funds_endpoint method to return the Mutual Funds API endpoint.
  • New File: tests/test_mutual_funds_tracker.py

    • Define tests for MutualFundsTracker class.
    • Test fetch_mutual_funds_trades method.
    • Test process_mutual_funds_trades method.

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced support for tracking mutual funds, including real-time trade fetching and processing.
    • Added configuration options for mutual funds tracking in the trading bot settings.
  • Bug Fixes

    • Enhanced error handling for mutual funds trade fetching and processing.
  • Tests

    • Added a new test suite for the MutualFundsTracker class to ensure the accuracy of trade fetching and processing functionalities.

Related to #8

Add real-time mutual funds trades tracking functionality.

* **New File: `data/mutual_funds_tracker.py`**
  - Define `MutualFundsTracker` class to handle real-time tracking of mutual funds trades.
  - Implement `fetch_mutual_funds_trades` method to fetch real-time mutual funds trades data.
  - Implement `process_mutual_funds_trades` method to process mutual funds trades data.

* **Update `main.py`**
  - Import `MutualFundsTracker` from `data/mutual_funds_tracker`.
  - Initialize `MutualFundsTracker` in the main function.
  - Add `mutual_funds_tracker` to the `process_market_data` function parameters.
  - Create a task to process mutual funds trades in `process_market_data` function.

* **Update `config/config.py`**
  - Add `mutual_funds_tracking_enabled` and `mutual_funds_data_source` settings under `investment_banking` section.

* **Update `config/api_config.py`**
  - Add `mutual_funds_api_key` and `mutual_funds_api_endpoint` settings.
  - Add `mutual_funds_headers` method to return headers for Mutual Funds API.
  - Add `get_mutual_funds_endpoint` method to return the Mutual Funds API endpoint.

* **New File: `tests/test_mutual_funds_tracker.py`**
  - Define tests for `MutualFundsTracker` class.
  - Test `fetch_mutual_funds_trades` method.
  - Test `process_mutual_funds_trades` method.
Copy link

coderabbitai bot commented Nov 25, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce enhancements to the trading bot's functionality by integrating support for a Mutual Funds API. This includes new configuration settings in api_config.py and config.py, the addition of a MutualFundsTracker class for real-time trade tracking in mutual_funds_tracker.py, and updates to main.py for processing mutual funds data. Additionally, a new test suite for the MutualFundsTracker class is created in test_mutual_funds_tracker.py to ensure proper functionality and coverage.

Changes

File Change Summary
config/api_config.py Added attributes mutual_funds_api_key and mutual_funds_api_endpoint. Added methods for headers and endpoint retrieval.
config/config.py Introduced parameters mutual_funds_tracking_enabled and mutual_funds_data_source in load_config.
data/mutual_funds_tracker.py Created MutualFundsTracker class with methods for fetching and processing mutual funds trades.
main.py Updated process_market_data to include mutual_funds_tracker, and integrated mutual funds processing.
tests/test_mutual_funds_tracker.py Added tests for MutualFundsTracker class, including methods for fetching and processing trades.

Poem

🐇 In the garden of finance, we hop and we play,
With mutual funds tracking, we brighten the day.
New keys and endpoints, oh what a delight,
Fetching and processing, our future is bright!
So here's to the changes, let’s cheer and rejoice,
In the world of investments, we’ve found our voice! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vishwamartur vishwamartur merged commit 678d6d3 into main Nov 25, 2024
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant