Skip to content

Conversation

ptbrowne
Copy link
Contributor

@ptbrowne ptbrowne commented Aug 27, 2025

⚠️ Cannot be merged yet as the dynamic tariffs predicate are not on production yet.

Description

  • Removed flag that was harcoding dynamic tariffs across all price components
  • Ability to see dynamic tariffs coming from Lindas
  • Dynamic tariffs banner only shown if some observations have dynamic tariffs

⚠️ Data only available on Int, all dynamic tariffs are at 0 at the moment.

Related Issues

Closes #164

Testing/Reproduction Steps

  1. Go to /municipality/5009?view=expanded&period=2026
  2. See that the dynamic tariffs are shown for the "total" price component
  3. If you go to 2025, no dynamic tariffs is shown as there is no data. The
    banner is also not shown since there are no dynamic tariffs

Checklist

  • I have tested my changes thoroughly
  • My commits use clear, descriptive messages
  • My PR includes only related changes
  • I have added an entry in the changelog

Notes for Reviewers

  • Dynamic tariffs data only available on Int for 2026 for specific municipalities,
    use the link above.

Known Limitations

  • Data in Lindas is only "0"
  • From what I understood, the dynamic tariffs are only relevant to the total, so
    I only show them there.

See my question here: https://jira.uvek.admin.ch/jira/browse/PELCOMDB-2369?focusedId=79024&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-79024

@ptbrowne ptbrowne requested a review from noahonyejese as a code owner August 27, 2025 10:10
Copy link

vercel bot commented Aug 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
elcom-electricity-price-website Ready Ready Preview Comment Aug 27, 2025 10:20am

@ptbrowne ptbrowne changed the title feat/dynamic tariffs Dynamic Tariffs from Lindas Aug 27, 2025
@ptbrowne ptbrowne force-pushed the feat/dynamic-tariffs branch from d8352fe to d63ff81 Compare August 27, 2025 10:13
@ptbrowne
Copy link
Contributor Author

Query showing that we have no dynamic tariffs data (not even the predicates, so we cannot merge, since the app would now look for the predicates) https://s.zazuko.com/UEBDua

@mevionfamos
Copy link
Contributor

mevionfamos commented Aug 28, 2025

so we cannot merge, since the app would now look for the predicates

@ptbrowne We could merge and push to ABN but not yet to PROD, correct?
Not sure how to test this, I tried https://elcom-electricity-price-website-git-feat-dynamic-tariffs-ixt1.vercel.app/municipality/3746?flag__dynamicElectricityTariffs=true&period=2025&view=collapsed

Also, I have clarified the requirements in #164:

  • The lowestrate and highestrate are indicating the price of the Network usage price component
  • Network operators can specify dynamic network usage prices if they want (e.g. different tariffs based on the time of day). If they do, they can now specify the highest and lowest (normalized) price that they charge → lowestrate and highestrate
  • This means that both the Network usage and the Total will be dynamic (as specified in the original design)
    • The dynamic values for the network usage we get from LINDAS
    • The dynamic values for the total we need to calculate ourselves (I think... as far as I understood based on the "fixed" network usage and the delta to the lowestrate/highestrate)
    • We still also get the 'normal' (non-dynamic) network usage, as this is the value used across the rest of the app. The dynamic values are not used for any calculations; only for the display in the price components break down
  • The current implementation on REF, showing dynamic values for all price components is wrong

As we are now planning to uplift ABN to PROD the day before the tariff release (with no staggered release) I would still suggest to merge this.

@ptbrowne
Copy link
Contributor Author

ptbrowne commented Sep 3, 2025

I had a quick look again, the fact that we need to calculate the total ourselves is problematic for the structure of the current code. Discussed offline: we wait until we have data.

@mevionfamos
Copy link
Contributor

Status EDES Jour Fixe 250911:

  • as of now, no operators have provided dynamic tariffs (a few are still outstanding, they have missed the press conference deadline)
  • when finalizing sunshine, we should also merge this PR and "activate" this functionality, in order not to keep this open and "forget about it"
  • ElCom is aware that this feature has not been tested with live data (only mock) and acknowledges the small risk this poses but they would reach out if they receive dynamic data and notice errors

@ptbrowne

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display Dynamic Tariffs

2 participants