Skip to content

Conversation

Rdataflow
Copy link
Contributor

ensure only Draft|Published are shown
WRT https://github.com/zazuko/cube-creator/wiki/LINDAS-Specifics#needed-attributes-that-a-cube-shows-up-on-visualizeadminch

there are rare cases with different status i.e. https://s.zazuko.com/m6iuJB which shouldn't be shown

nb: this PR also makes results more consistent with

isPublished
? [ns.adminVocabulary("CreativeWorkStatus/Published")]
: [
ns.adminVocabulary("CreativeWorkStatus/Draft"),
ns.adminVocabulary("CreativeWorkStatus/Published"),
]

cc @bprusinowski

Copy link

vercel bot commented May 8, 2024

@Rdataflow is attempting to deploy a commit to the Interactive Things Team on Vercel.

A member of the Team first needs to authorize it.

@bprusinowski
Copy link
Collaborator

Thanks @Rdataflow, LGTM! Side note: I think this situation technically shouldn't happen, looking at the below screenshot? Maybe it could be possible with some custom pipeline? 🤔

Screenshot 2024-05-08 at 08 54 11

Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 7:07am

@Rdataflow
Copy link
Contributor Author

Rdataflow commented May 8, 2024

@bprusinowski it's likely due to a combination of legacy C-C projects and code in C-C that doesn't expire deprecated cubes properly 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants