added custom color palette e2e tests #2124
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
noahonyejese
changed the title
There was a problem hiding this comment.
LGTM, thanks @noahonyejese 🙇♂️ Only one question on removing the palettes :)
|
@bprusinowski not sure why one of the tests is failing - do you maybe know? |
|
@noahonyejese I checked the blob report from the failed test, and it looks like we have a "Error: locator.isVisible: Error: strict mode violation: getByText('Categorical Palette') resolved to 2 elements" error. Looking at Argos screenshot, in fact there are two palette names that contain this string – I think you'd need to try to match by exact text, not only by checking if an element "contains text"? |
Not sure because it was working on local |
|
@noahonyejese yes, but here the user had a TEST CATEGORICAL PALETTE added, coming from a database, that you probably didn't have on local 🤔 |
I mean adjusted it now it should use the approach you mentioned but it still doesn't seem to work - I will get back to this PR once completing the higher priority stuff. @bprusinowski |
|
@bprusinowski where can I get the blob report? |
|
@noahonyejese it looks like something's still off with setting the custom color palettes in end-to-end tests, see the screenshot of failed action there: https://app.argos-ci.com/interactive-things/visualization-tool/builds/452/140680285 It looks like a palette with this name already exists 🤔 |
2 participants
This PR adds an e2e test for custom color palettes on the profile page.