perf: Multistage Docker build #2200
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wereHamster
reviewed
Mar 24, 2025
|
|
||
| EXPOSE 3000 | ||
|
|
||
| # Instead of running npm start; handle signals (SIGINT/SIGTERM) properly |
There was a problem hiding this comment.
Newer versions of Next.js require ENV HOSTNAME=0.0.0.0. Might be worth adding it today to not get any surprises when you upgrade Next.js in the future.
See official Docker example: https://github.com/vercel/next.js/blob/62ac6d040183d48a5d83d2b197826c0c471caa62/examples/with-docker/Dockerfile#L65
Comment on lines
+95
to
+101
| # The file that Next.js generates is CommonJS, but the frontend folder has a | ||
| # package.json with type:module, so node expects ESM when files have a .js | ||
| # extension. | ||
| # | ||
| # This should eventually be fixed in Next.js, but for the time being adjusting | ||
| # the extension seems to be the easiest path forward (thanks @wereHamster!) | ||
| RUN mv ./app/server.js ./app/server.cjs |
There was a problem hiding this comment.
This project does not use type:module, so renaming the file to add the .cjs extension is not necessary. And I believe the latest Next.js works without this workaround (if you ever decide to switch to type:module).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
This PR...
How to test