Skip to content

Extra context of query file execution #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kremio
Copy link

@kremio kremio commented Jan 31, 2025

While pg-promise already provides the full query as it was sent to the DB in the context object that is provided to the error callback, with large or complex queries being able to get the path to the source SQL file and the values passed to it when running the query would be really helpful for debugging and monitoring purposes.

The proposed changes add the path to the query file and the values used to execute it to the EventContext.

@kremio kremio marked this pull request as ready for review January 31, 2025 09:50
@vitaly-t
Copy link
Owner

Sorry, I overlooked this PR in the last update, because such changes need tests + documentation updates, which you did not provide. I will look at it later.

@kremio
Copy link
Author

kremio commented Mar 11, 2025

No worries, and thanks for the feedback. I'll try and add a test and updates to the docs in the coming days.

@vitaly-t
Copy link
Owner

@kremio It's been 2 weeks since ;) Are you still planning to update it?

@kremio
Copy link
Author

kremio commented Apr 1, 2025

@vitaly-t A few days turned into a few weeks, but here are the updates to the tests and docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants