service-workers and search params#769
Open
Iran-110 wants to merge 6 commits into
Open
Conversation
✅ Deploy Preview for vite-plugin-pwa-legacy ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
|
This should also work in dev mode, have you check it with some example? I'll try to review this PR next weekend (too busy, sorry ) Revert changes added to the docs, those changes should go to the docs repo here: https://github.com/vite-pwa/docs Changes made to the examples won't pass Playwright tests (update PWA tests in the corresponding client-test folders or add an example only to some example not included in PW tests, check |
This reverts commit 7988711.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For advanced use of service workers, such as versioning or complex caching, we sometimes need to send data to the service worker using search parameters like
/sw.js?ver=1.2.This PR helps to solve this issue.
Linked Issues
resolves #587.
Additional Context
I use this pattern: #587 (comment)