fix(plugin-rsc): move onClientReference to wrapResourceProxy and fix dev #1073
Merged
fix(plugin-rsc): move onClientReference to wrapResourceProxy and fix dev #1073
onClientReference to wrapResourceProxy and fix dev #1073Conversation
hi-ogawa
changed the title
onClientReference notification into wrapResourceProxyonClientReference notification into wrapResourceProxy
hi-ogawa
changed the title
onClientReference notification into wrapResourceProxyonClientReference during dev
commit: |
hi-ogawa
changed the title
onClientReference during devonClientReference to wrapResourceProxy and fix dev
…pResourceProxy` Consolidate client reference notification by moving it into the resource proxy getter, which is called on every export access (not memoized by React). This eliminates the separate `onLoad` callback mechanism. - Remove `onLoad` option from `setRequireModule` - Add `id` parameter to `wrapResourceProxy` and make `deps` required - Notify `onClientReference` early in `load` (production) alongside preload - Notify `onClientReference` in proxy getter for per-request asset collection Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
hi-ogawa
force-pushed
the
refactor/rsc-on-client-reference
branch
from
ef5495f to
5406e46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onLoadcallback mechanism fromsetRequireModuleonClientReferenceearly inload(production) alongside preload, and in proxy getter for per-request asset collectionSupersedes closes #1070
🤖 Generated with Claude Code