test(plugin-rsc): add ReadableStream polyfill for WebKit/Safari support#1076
Closed
test(plugin-rsc): add ReadableStream polyfill for WebKit/Safari support#1076
Conversation
Safari doesn't implement ReadableByteStreamController, which causes browser-only RSC examples to fail. This adds web-streams-polyfill to conditionally polyfill ReadableStream when needed, enabling WebKit e2e tests. Based on https://github.com/gaearon/rscexplorer/blob/main/src/shared/polyfill.ts Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
hi-ogawa
changed the title
Add console logging to tests to help debug WebKit issues. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The polyfill needs to be imported before @vitejs/plugin-rsc/browser and entry.rsc so the dynamic import of web-streams-polyfill starts before react-server-dom-webpack is evaluated. Also reverts the unnecessary ReadableByteStreamController polyfill - only ReadableStream needs to be polyfilled (like rscexplorer does). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
web-streams-polyfillto browser and browser-mode examples to polyfillReadableStreamfor Safari/WebKit which doesn't implementReadableByteStreamControllerbrowser.test.tsandbrowser-mode.test.tse2e testsTest plan
pnpm exec playwright test e2e/browser.test.ts e2e/browser-mode.test.ts --project=webkit🤖 Generated with Claude Code